Page MenuHomeSolus

Update mono to 5.18.1.0
AbandonedPublic

Authored by watpi on Jan 22 2019, 5:45 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Summary
Test Plan

Successfully rebuild dependencies

  • mono-basic
  • openra
  • keepass
  • fsharp
  • pinta
  • godot
  • nuget

Diff Detail

Repository
R2091 mono
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

watpi created this revision.Jan 22 2019, 5:45 PM
watpi requested review of this revision.Jan 22 2019, 5:45 PM
Jacalz added a subscriber: Jacalz.Jan 22 2019, 6:38 PM

You don’t need to submit the rebuilds. There is a reason that there is a tag named “needs rebuilds”...

The only times when you need to submit rebuilds are when the package needs an update or patch to work with the new version that you are building against.

have you tested a few applications like keepass, pinta, ... ?

You missed

  • mono-msbuild (which won't build because there is a missing dependency)
  • monodevelop

As @Jacalz you should use the Requires Rebuilds tag instead of submitting all the patches

have you tested a few applications like keepass, pinta, ... ?
You missed

  • mono-msbuild (which won't build because there is a missing dependency)

mono-msbuild should also be rebased so that it builds using itself instead of using what Ubuntu provides.

watpi edited the test plan for this revision. (Show Details)Jan 23 2019, 12:29 PM
watpi added a project: Requires Rebuilds.

have you tested a few applications like keepass, pinta, ... ?

Yes, keepass and pinta should work. Also OpenRA launches (I don't have the assets from the original game so can't get further).

mono-msbuild 15.8 builds successfully

@watpi could you please update to 5.18.1.0
The nuget tarball url is : https://joshuastrobl.com/solus-tarballs/nuget2-2.11.tar.xz

Thanks 😄

watpi updated this revision to Diff 14178.Mar 30 2019, 2:49 PM
watpi edited the test plan for this revision. (Show Details)

Update to 5.18.1.0

watpi added a comment.EditedMar 30 2019, 3:15 PM

Successful rebuilds

  • mono-msbuild
  • mono-basic
  • openra
  • keepass
  • fsharp
  • nuget

Unsuccessful rebuilds

  • pinta
checking for suffix of object files... configure: error: in `/home/build/YPKG/root/pinta/build/pinta-1.7':
configure: error: cannot compute suffix of object files: cannot compile
See `config.log' for more details
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-setup2L3AOx']' returned non-zero exit status 1
[Build] setup failed
  • godot
[Initial build] Compiling ==> platform/x11/crash_handler_x11.cpp
ccache: error: Failed to create temporary file for /home/build/.ccache/tmp/crash_hand.stdout: Permission denied
[Initial build] scons: *** [platform/x11/crash_handler_x11.x11.opt.tools.64.llvm.o] Error 1
Compiling ==> platform/x11/context_gl_x11.cpp
ccache: error: Failed to create temporary file for /home/build/.ccache/tmp/context_gl.stdout: Permission denied
scons: *** [platform/x11/context_gl_x11.x11.opt.tools.64.llvm.o] Error 1
scons: building terminated because of errors.
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-buildliJNk9']' returned non-zero exit status 2
[Build] build failed

pinta builds fine here, for godot you have to use D5865

pinta builds fine here, for godot you have to use D5865

Yes, got them to build too. It was a solbuild misconfiguration

watpi updated this revision to Diff 14278.Apr 1 2019, 12:48 PM

Update mono to 5.18.1.0

watpi retitled this revision from Update mono to 5.18.0.240 to Update mono to 5.18.1.0.Apr 1 2019, 12:49 PM
watpi edited the test plan for this revision. (Show Details)
DataDrake accepted this revision.May 21 2019, 12:32 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.May 21 2019, 12:32 AM
JoshStrobl abandoned this revision.Thu, Sep 12, 6:39 AM