Page MenuHomeSolus

Rebuild against rust 1.32 and cargo 0.32
AbandonedPublic

Authored by josephscade on Jan 18 2019, 6:01 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

New rust and cargo release bring new optimizations that rustup can benefit

Test Plan

Run rustup install stable as a regular user.
Add ~/.cargo/bin to $PATH
You should now be able to execute cargo and rustc.

Diff Detail

Repository
R4626 rustup
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
josephscade created this revision.Jan 18 2019, 6:01 PM
josephscade requested review of this revision.Jan 18 2019, 6:01 PM
Girtablulu added a subscriber: Girtablulu.EditedJan 18 2019, 6:18 PM

erm what are you actually planning to do? Because this is not how rebuild works

josephscade retitled this revision from Rebuild against rust 1.26 and cargo 0.32 to Rebuild against rust 1.32 and cargo 0.32.Jan 18 2019, 6:36 PM

Sorry, I will try to provide the patches the way you want them tomorrow.
(I don't know what happened in my head, but I was thinking about rust 1.32)

Sorry, I will try to provide the patches the way you want them tomorrow.
(I don't know what happened in my head, but I was thinking about rust 1.32)

you really don't need to send in a diff for a rebuild, we can execute one easily after we built rust successfully :)

Ow sorry, I just wanted to help you :(
So I confirm that a rebuild for rustup should be triggered each time rust is updated

Thank you for being so nice with me with unexperienced contributors :)

josephscade abandoned this revision.Jan 18 2019, 8:37 PM

No issue and thx for the confirming but It's for me simpler and faster for me to do rebuilds but I'll keep it in mind in the future to remember rebuilding :)