Page MenuHomeSolus

Update alacritty to 0.2.8
ClosedPublic

Authored by robertgzr on Jan 12 2019, 6:07 PM.

Details

Summary

Changelog can be found here.

Signed-off-by: Robert Günzler <r@gnzler.io>

Test Plan

using this as my daily driver without issues

Diff Detail

Repository
R4608 alacritty
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
robertgzr created this revision.Jan 12 2019, 6:07 PM
robertgzr requested review of this revision.Jan 12 2019, 6:07 PM

forgot to add the updated pspec -.-

robertgzr updated this revision to Diff 12316.Jan 12 2019, 6:22 PM

Update pspec

DataDrake accepted this revision.Jan 16 2019, 12:29 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 16 2019, 12:29 PM
JoshStrobl edited the summary of this revision. (Show Details)Jan 18 2019, 8:16 AM
sborer added a subscriber: sborer.Jan 21 2019, 9:59 PM

In the meantime 0.2.6 and 0.2.7 have been released.
0.2.6 includes the high-cpu fix so the patch would become unnecessary.

In D5048#81612, @sborer wrote:

In the meantime 0.2.6 and 0.2.7 have been released.

Github is supposed to notify me about releases of alacritty :/
Pushing an update now...

Awesome thanks, building it myself right now. :)

robertgzr updated this revision to Diff 12478.Jan 21 2019, 10:13 PM

Include 0.2.6 and 0.2.7

sborer added a comment.Feb 3 2019, 5:53 PM

Hi

I don't want to sound rude, rather I'm curious and a little irritated as why this is set as "accepted" since at least two weeks but no changes are seen in the upstream repo?
And no updated build is found even in the unstable repo since 17. december?

I'm not so familiar with Phabricator and the update procedures of Solus in general so I would appreciate if someone could explain me what's going on.
Thanks!

You have to keep in mind that the solus team is not the biggest so it sometimes takes a while... and this is foss after all so they don't really owe you anyting ;)

@DataDrake do you need anything else here? I've been running 0.2.7 without issues

robertgzr requested review of this revision.Feb 7 2019, 5:39 PM
JoshStrobl accepted this revision.Feb 8 2019, 5:13 PM
This revision is now accepted and ready to land.Feb 8 2019, 5:13 PM
JoshStrobl requested changes to this revision.EditedFeb 8 2019, 5:15 PM

You didn't update this against our alacritty repo. Not to mention summary and diff title is out of date.

This revision now requires changes to proceed.Feb 8 2019, 5:15 PM

You didn't update this against our alacritty repo

What does that mean? I went into repo from which I submitted the original package and did arc diff, do I need to do anything else? In the meantime v0.2.8 was released so I will just push another update including that

robertgzr updated this revision to Diff 12969.Feb 10 2019, 10:21 PM

Include 0.2.8

robertgzr retitled this revision from Update alacritty to 0.2.5 to Update alacritty to 0.2.8.Feb 10 2019, 10:22 PM
robertgzr edited the summary of this revision. (Show Details)
robertgzr edited the test plan for this revision. (Show Details)

You didn't update this against our alacritty repo

What does that mean? I went into repo from which I submitted the original package and did arc diff, do I need to do anything else? In the meantime v0.2.8 was released so I will just push another update including that

Yes, you need to update it against our repo. As in R4608.

JoshStrobl requested changes to this revision.Feb 10 2019, 11:48 PM
This revision now requires changes to proceed.Feb 10 2019, 11:48 PM
JoshStrobl accepted this revision.Feb 18 2019, 5:58 AM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 18 2019, 5:58 AM
This revision was automatically updated to reflect the committed changes.