Page MenuHomeSolus

Split godot into Classical and Mono
ClosedPublic

Authored by kyrios123 on Jan 10 2019, 9:59 PM.

Details

Summary

Also add mono-msbuild as runtime dependency for the mono version because I forgot to add it in the previous release.
Resolves T7457

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Confirmed working by users (see comments in T7457)

Diff Detail

Repository
R1031 godot
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kyrios123 created this revision.Jan 10 2019, 9:59 PM
kyrios123 requested review of this revision.Jan 10 2019, 9:59 PM
kyrios123 edited the test plan for this revision. (Show Details)Jan 12 2019, 5:33 PM
livingsilver94 added inline comments.
package.yml
15

Typo here!
And to be very, very picky, C# has a capital C :)

kyrios123 updated this revision to Diff 12317.Jan 12 2019, 6:58 PM

C# because @livingsilver94 told me that case sensitivity does matter!

C# because @livingsilver94 told me that case sensitivity does matter!

LOL!
Guess you skipped my part about the typo. "Resources" is with only one 's' :)

C# because @livingsilver94 told me that case sensitivity does matter!

LOL!
Guess you skipped my part about the typo. "Resources" is with only one 's' :)

It wasn't a typo, that's because english can't spell ressources correctly ๐Ÿ˜›

kyrios123 updated this revision to Diff 12321.Jan 12 2019, 9:02 PM

Learn to write in english

DataDrake requested changes to this revision.Jan 16 2019, 12:44 PM
DataDrake added a subscriber: DataDrake.

Can we rename the base package to godot-classic, use the ^ reset so that the sub-packages are godot-common and godot-mono, and then use a replaces: for godot-mono with respect to godot? That way there's no confusion as to what is what and when people update, they will still have the mono version installed.

This revision now requires changes to proceed.Jan 16 2019, 12:44 PM
kyrios123 updated this revision to Diff 12395.EditedJan 16 2019, 9:10 PM
  • godot-classic (main package)
  • godot-mono -> replaces godot
  • godot-common

And the PR to deprecate godot

Landed PR however won't push repo_data change until @DataDrake reviews patch.

DataDrake accepted this revision.Jan 29 2019, 1:50 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 29 2019, 1:50 PM
This revision was automatically updated to reflect the committed changes.