Page MenuHomeSolus

Split godot into Classical and Mono
Needs ReviewPublic

Authored by kyrios123 on Thu, Jan 10, 9:59 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T7457: Godot vanilla version (without Mono)
Summary

Also add mono-msbuild as runtime dependency for the mono version because I forgot to add it in the previous release.
Resolves T7457

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Confirmed working by users (see comments in T7457)

Diff Detail

Repository
R1031 godot
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
kyrios123 created this revision.Thu, Jan 10, 9:59 PM
kyrios123 requested review of this revision.Thu, Jan 10, 9:59 PM
kyrios123 edited the test plan for this revision. (Show Details)Sat, Jan 12, 5:33 PM
livingsilver94 added inline comments.
package.yml
15

Typo here!
And to be very, very picky, C# has a capital C :)

kyrios123 updated this revision to Diff 12317.Sat, Jan 12, 6:58 PM

C# because @livingsilver94 told me that case sensitivity does matter!

C# because @livingsilver94 told me that case sensitivity does matter!

LOL!
Guess you skipped my part about the typo. "Resources" is with only one 's' :)

C# because @livingsilver94 told me that case sensitivity does matter!

LOL!
Guess you skipped my part about the typo. "Resources" is with only one 's' :)

It wasn't a typo, that's because english can't spell ressources correctly πŸ˜›

kyrios123 updated this revision to Diff 12321.Sat, Jan 12, 9:02 PM

Learn to write in english

DataDrake requested changes to this revision.Wed, Jan 16, 12:44 PM
DataDrake added a subscriber: DataDrake.

Can we rename the base package to godot-classic, use the ^ reset so that the sub-packages are godot-common and godot-mono, and then use a replaces: for godot-mono with respect to godot? That way there's no confusion as to what is what and when people update, they will still have the mono version installed.

This revision now requires changes to proceed.Wed, Jan 16, 12:44 PM
kyrios123 updated this revision to Diff 12395.EditedWed, Jan 16, 9:10 PM
  • godot-classic (main package)
  • godot-mono -> replaces godot
  • godot-common

And the PR to deprecate godot

Landed PR however won't push repo_data change until @DataDrake reviews patch.