Page MenuHomeSolus

Initial release of strawberry
ClosedPublic

Authored by Girtablulu on Jan 10 2019, 4:00 PM.

Details

Summary

Initial release of strawberry
Resolves T7475
Depends on D4957

Test Plan

Played a view songs from my music libary created different playlists

Diff Detail

Repository
R4656 strawberry
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Jan 10 2019, 4:00 PM
Girtablulu requested review of this revision.Jan 10 2019, 4:00 PM
JoshStrobl edited the summary of this revision. (Show Details)Jan 10 2019, 4:03 PM
Girtablulu updated this revision to Diff 12276.Jan 10 2019, 4:04 PM

Fix builddeps

JoshStrobl requested changes to this revision.Jan 10 2019, 4:11 PM
JoshStrobl added a subscriber: JoshStrobl.

Not a quality patch. Bunch of redundant deps, you didn't sort them completely, etc.

package.yml
15

You've been packaging for how long and you're still adding system.devel pkgconfigs?

19

You realize like a million things depend on this, right?

22

qt5-base-devel is a dep of qt5-x11extras-devel

This revision now requires changes to proceed.Jan 10 2019, 4:11 PM
JoshStrobl added inline comments.Jan 10 2019, 4:21 PM
package.yml
15

You still did not address the dbus item. Line shifted up to 14 at this point. I want you to go through all the builddeps again and double check.

19

You still did not address the gio-2.0 item. Line shifted up to 18 at this point. I want you to go through all the builddeps again and double check.

Blah it showed an edit thing on this for whatever reason...

Girtablulu updated this revision to Diff 12286.Jan 10 2019, 9:11 PM

Fix that mess I made

Girtablulu updated this revision to Diff 12287.Jan 10 2019, 9:14 PM

Alphabetical order is hard

Add support for other services

JoshStrobl accepted this revision.Jan 11 2019, 6:37 PM

Much better ๐Ÿ‘

This revision is now accepted and ready to land.Jan 11 2019, 6:37 PM
Girtablulu updated this revision to Diff 12328.Jan 13 2019, 1:33 PM

Update strawberry to 0.5.1

DataDrake accepted this revision.Jan 13 2019, 1:36 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was automatically updated to reflect the committed changes.