Page MenuHomeSolus

Update Mailspring 1.5.5
ClosedPublic

Authored by alecbcs on Jan 6 2019, 10:00 PM.

Details

Summary

Updated Mailspring to 1.5.5 which includes new features and bug fixes.

Changelog:

  • Mailspring now shows visual previews of PDF, DOCX, XLSX, XLS, CSV, and Markdown attachments. Selecting an attachment in the message view and pressing the space bar or clicking the small "eye" icon shows a preview of the contents in a new window, so you can finally view PDFs, etc. without leaving your Mailbox!
  • In dark mode, text in message bodies is no longer black.
  • The copy and cut context menu items are disabled when right-clicking a password field.
  • The Brazillian Portuguese translation has been improved!
  • You can now view Mailspring's open source license and all of it's dependencies' licenses and copyright notices from the menu.
Test Plan

Tested 1.5.5 by opening, sending, and receiving emails from a Gmail account. Everything looked and functioned as expected.

Diff Detail

Repository
R3879 mailspring
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alecbcs created this revision.Jan 6 2019, 10:00 PM
alecbcs requested review of this revision.Jan 6 2019, 10:00 PM

Seems weird that this is shipping its own libEGL.so and libGLESv2.so. Is there any reason this can't use system libs?

JoshStrobl edited the summary of this revision. (Show Details)Jan 7 2019, 9:12 PM
JoshStrobl requested changes to this revision.Jan 7 2019, 9:21 PM
JoshStrobl added a subscriber: JoshStrobl.

Seems weird that this is shipping its own libEGL.so and libGLESv2.so. Is there any reason this can't use system libs?

Based on their release note item for 1.5.5 (which was removed from the above mentioned summary, likely for not being specifically relevant to Solus), it appears it was their way of handling older operating systems shipping with too old of libglvnd for Electron 4. I would strongly recommend that @alecbcs try removing their SO files and symlinking to ours instead.

Their release notes:

Mailspring no longer crashes with a fatal error on CentOS, Red Hat Enterprise Linux (RHEL) 7.6 with a "CXXABI_1.3.9" message. When we upgraded to Electron 4, using GCC++5 to build parts of Mailspring resulted in libraries too new for some linux platforms.

This revision now requires changes to proceed.Jan 7 2019, 9:21 PM
alecbcs updated this revision to Diff 12226.Jan 8 2019, 3:36 PM
  • Patch Mailspring to use system libraries.
JoshStrobl requested changes to this revision.Jan 8 2019, 9:26 PM

Also (this isn't a blocker), are there any Desktop Actions that Mailspring support, any command-line args that may be worthy of having a desktop action for, etc.? Thinking about T7289

package.yml
18

Likely no reason to have this if they're not actually going to be using it.

21–22

Not needed, dep of libgtk-3-devel and libxtst-devel

25–26

Have this after gnome-keyring on line 30.

27–28

: | should be aligned with the one from install. It's the little things.

39–40

Should be /usr/lib64 really.

This revision now requires changes to proceed.Jan 8 2019, 9:27 PM
alecbcs updated this revision to Diff 12236.Jan 8 2019, 10:40 PM
alecbcs marked 5 inline comments as done.
  • Fix redundant dependencies and change to use lib64.

Also (this isn't a blocker), are there any Desktop Actions that Mailspring support, any command-line args that may be worthy of having a desktop action for, etc.? Thinking about T7289

From what I can tell Mailspring doesn't have any command accessible shortcuts. However, it does implement a shortcuts menu (right-clicking the tray icon) so I think it won't be too hard to work with the upstream developers to get this implemented for the desktop shortcut as well.

Submitted a feature request for better desktop actions with the upstream developers here.

JoshStrobl accepted this revision.Jan 8 2019, 11:20 PM

Fantastic, thank you for making a task. I'll sub to it :) Patch LGTM.

This revision is now accepted and ready to land.Jan 8 2019, 11:20 PM
This revision was automatically updated to reflect the committed changes.