Page MenuHomeSolus

Update granite to 5.2.2
ClosedPublic

Authored by Skyeun on Jan 6 2019, 3:25 PM.

Details

Summary

Updated granite to the latest version 5.2.2.

Changes:

  • Utils: Ignore empty accel strings
  • Updated translations
Test Plan

Installed in a VM alongside 'pantheon-terminal' with everything working as expected.

Diff Detail

Repository
R1052 granite
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Skyeun created this revision.Jan 6 2019, 3:25 PM
Skyeun requested review of this revision.Jan 6 2019, 3:25 PM
DataDrake accepted this revision.Jan 7 2019, 12:46 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 7 2019, 12:46 PM
DataDrake requested changes to this revision.Jan 8 2019, 1:36 AM

Missing abi_symbols changes. Are you not using solbuild via common?

This revision now requires changes to proceed.Jan 8 2019, 1:36 AM
Skyeun updated this revision to Diff 12215.Jan 8 2019, 6:26 AM
This comment was removed by Skyeun.
Skyeun added a comment.Jan 8 2019, 6:31 AM

Sorry, I made a mistake with my local git branch and need to create a new diff :/

Skyeun updated this revision to Diff 12217.Jan 8 2019, 8:07 AM
  • Added abi_symbols
Skyeun added a comment.Jan 8 2019, 8:09 AM

Okay, found the issue, I was using sudo solbuild build instead of sudo make. Sorry for the trouble

In D4970#79880, @Skyeun wrote:

Okay, found the issue, I was using sudo solbuild build instead of sudo make. Sorry for the trouble

Only need to run make per the docs https://getsol.us/articles/packaging/building-a-package/en/#building-packages-solus-only

DataDrake accepted this revision.Jan 8 2019, 2:59 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 8 2019, 2:59 PM
Closed by commit R1052:e4e7c9f63cc5: Update granite to 5.2.2 (authored by Eressea <eressea6666@gmail.com>, committed by DataDrake). · Explain WhyJan 8 2019, 3:01 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a subscriber: JoshStrobl.EditedJan 11 2019, 8:19 PM

Upgrading this broke Tootle as a result of Granite requiring non-existent schemas. Noticed it when I went to go do a social media posting on my personal account and the Solus one. See this issue in Granite that caused it and upstream Tootle issue.

I'm going to be patching Granite to revert the change.

Resolved the matter, commented upstream.