Paths

Table of Contentst

Differential D4970

Update granite to 5.2.2
ClosedPublic
Actions

Authored by Skyeun on Jan 6 2019, 3:25 PM.

Tags

None

Referenced Files

	F10792389: D4970.id12217.diff
	May 27 2023, 7:08 AM

	F10791534: D4970.id12215.diff
	May 27 2023, 3:39 AM

	F10791509: D4970.diff
	May 27 2023, 3:30 AM

	F10791497: D4970.id12222.diff
	May 27 2023, 3:26 AM

	F10791451: D4970.id12090.diff
	May 27 2023, 3:17 AM

	F10727205: D4970.diff
	May 9 2023, 7:17 PM

	F10713470: D4970.diff
	May 3 2023, 3:23 AM

	F10693107: D4970.id12090.diff
	Apr 24 2023, 7:41 PM

View All 9 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R1052:e4e7c9f63cc5: Update granite to 5.2.2

Summary

Updated granite to the latest version 5.2.2.

Changes:

Utils: Ignore empty accel strings
Updated translations

Test Plan

Installed in a VM alongside 'pantheon-terminal' with everything working as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Skyeun created this revision.Jan 6 2019, 3:25 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 6 2019, 3:25 PM

Skyeun requested review of this revision.Jan 6 2019, 3:25 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 7 2019, 12:46 PM

Missing abi_symbols changes. Are you not using solbuild via common?

This revision now requires changes to proceed.Jan 8 2019, 1:36 AM

Skyeun updated this revision to Diff 12215.Jan 8 2019, 6:26 AM

This comment was removed by Skyeun.

Sorry, I made a mistake with my local git branch and need to create a new diff :/

JoshStrobl mentioned this in D5003: Update granite to 5.2.2.Jan 8 2019, 7:34 AM

Added abi_symbols

Okay, found the issue, I was using sudo solbuild build instead of sudo make. Sorry for the trouble

In D4970#79880, @Skyeun wrote:

Okay, found the issue, I was using sudo solbuild build instead of sudo make. Sorry for the trouble

Only need to run make per the docs https://getsol.us/articles/packaging/building-a-package/en/#building-packages-solus-only

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 8 2019, 2:59 PM

Closed by commit R1052:e4e7c9f63cc5: Update granite to 5.2.2 (authored by Eressea <eressea6666@gmail.com>, committed by DataDrake). · Explain WhyJan 8 2019, 3:01 PM

This revision was automatically updated to reflect the committed changes.

Upgrading this broke Tootle as a result of Granite requiring non-existent schemas. Noticed it when I went to go do a social media posting on my personal account and the Solus one. See this issue in Granite that caused it and upstream Tootle issue.

I'm going to be patching Granite to revert the change.

Resolved the matter, commented upstream.

Revision Contents
Changeset List

Path

Size

2 lines

6 lines

pspec_x86_64.xml

16 lines

Diff 12222

abi_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...