Page MenuHomeSolus

Update protobuf to 3.6.1
ClosedPublic

Authored by Girtablulu on Jan 5 2019, 1:25 PM.

Details

Summary

Update protobuf to 3.6.1
Is needed to fix astroid
Changelog:

  • Introduced workaround for Windows issue with std::atomic and std::once_flag initialization
  • Added compatibility with PHP 7.3
  • Fixed Ruby crash involving Any encoding
Test Plan

build astroid against it and started it succesffully, additional tested softwate 'bitcoin' mosh mixx vlc compiz

Diff Detail

Repository
R2484 protobuf
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Girtablulu created this revision.Jan 5 2019, 1:25 PM
Girtablulu requested review of this revision.Jan 5 2019, 1:25 PM
DataDrake requested changes to this revision.Jan 7 2019, 12:53 PM
DataDrake added a subscriber: DataDrake.

Given the large number of changes, especially to libprotoc, I need to seed testing for *all* revdeps. Thanks!

This revision now requires changes to proceed.Jan 7 2019, 12:53 PM
Girtablulu updated this revision to Diff 12244.Jan 9 2019, 1:31 AM
Girtablulu edited the test plan for this revision. (Show Details)

Updating test plan

DataDrake accepted this revision.Jan 9 2019, 6:10 PM

LGTM . Thanks!

This revision is now accepted and ready to land.Jan 9 2019, 6:10 PM
This revision was automatically updated to reflect the committed changes.