Paths

Table of Contentst

Differential D4913

Initial inclusion of fprintd
ClosedPublic
Actions

Authored by abdulocracy on Jan 1 2019, 4:35 PM.

Tags

None

Referenced Files

	F11037612: D4913.id12134.diff
	Wed, Aug 9, 8:59 PM

	F11037611: D4913.id13026.diff
	Wed, Aug 9, 8:59 PM

	F11037610: D4913.id12218.diff
	Wed, Aug 9, 8:59 PM

	F11037609: D4913.id.diff
	Wed, Aug 9, 8:59 PM

	F11037608: D4913.id12231.diff
	Wed, Aug 9, 8:59 PM

	F11037607: D4913.id12232.diff
	Wed, Aug 9, 8:59 PM

	F11037606: D4913.id12219.diff
	Wed, Aug 9, 8:59 PM

	F11037605: D4913.id11991.diff
	Wed, Aug 9, 8:59 PM

View All 32 Files

Subscribers

Tokens

"Manufacturing Defect?" token, awarded by Jacalz.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T3574: Biometrics support for UPEK fingerprint scanner.

Commits

R4664:2224915bc5fe: Initial inclusion of fprintd

Summary

Inclusion of fprintd fixes T3574.

Test Plan

Install fprintd, enroll fingerprint, verify fingerprint.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

abdulocracy created this revision.Jan 1 2019, 4:35 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 1 2019, 4:35 PM

abdulocracy requested review of this revision.Jan 1 2019, 4:35 PM

Jacalz awarded a token.Jan 1 2019, 5:30 PM

DataDrake requested changes to this revision.Jan 7 2019, 1:09 PM

DataDrake added a subscriber: DataDrake.

DataDrake added inline comments.

package.yml
12	Should be sorted alphabetically.

This revision now requires changes to proceed.Jan 7 2019, 1:09 PM

Alphabetize builddeps.

abdulocracy marked an inline comment as done.Jan 7 2019, 1:57 PM

DataDrake requested changes to this revision.Jan 7 2019, 3:38 PM

DataDrake added inline comments.

pspec_x86_64.xml
22	Sorry, missed this before, should be in: /usr/share/dbus-1/system.d

This revision now requires changes to proceed.Jan 7 2019, 3:38 PM

kyrios123 added a subscriber: kyrios123.Jan 7 2019, 5:29 PM

kyrios123 added inline comments.

package.yml
20	How about using `tmpfiles` for this ?
pspec_x86_64.xml
30	also `--disable-static`

der_eismann added a subscriber: der_eismann.Jan 7 2019, 7:26 PM

der_eismann added inline comments.

package.yml
20	Also please make it shorter -> `install -dm00644` (or are we not doing this anymore @kyrios123?)

Fix dbus_confdir, add gtk-doc as builddep.

abdulocracy marked 2 inline comments as done.Jan 8 2019, 9:18 AM

Disable static libs.

abdulocracy marked an inline comment as done.Jan 8 2019, 9:25 AM

abdulocracy added inline comments.Jan 8 2019, 12:46 PM

package.yml
20	Haven't used it before, what would the ownership of the directory look like (UID, GID)?

DataDrake added inline comments.Jan 8 2019, 2:58 PM

package.yml
20	Should just me `install -d` for directories. Directories should are 00755 by default and that is fine for packaging.
20	root : root
pspec_x86_64.xml
30	Nice catch.

Remove -m00644.

abdulocracy marked an inline comment as done.Jan 8 2019, 6:01 PM

Use tmpfiles.

abdulocracy marked 3 inline comments as done.Jan 8 2019, 6:22 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 9 2019, 6:11 PM

Closed by commit R4664:2224915bc5fe: Initial inclusion of fprintd (authored by abdulocracy, committed by DataDrake). · Explain WhyFeb 14 2019, 12:55 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

11 lines

20 lines

pspec_x86_64.xml

120 lines

Diff 12134

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...