Page MenuHomeSolus

Initial inclusion of fprintd
ClosedPublic

Authored by abdulocracy on Jan 1 2019, 4:35 PM.

Details

Summary

Inclusion of fprintd fixes T3574.

Test Plan

Install fprintd, enroll fingerprint, verify fingerprint.

Diff Detail

Repository
R4664 fprintd
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

abdulocracy created this revision.Jan 1 2019, 4:35 PM
abdulocracy requested review of this revision.Jan 1 2019, 4:35 PM
Jacalz awarded a token.Jan 1 2019, 5:30 PM
DataDrake requested changes to this revision.Jan 7 2019, 1:09 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
12

Should be sorted alphabetically.

This revision now requires changes to proceed.Jan 7 2019, 1:09 PM
abdulocracy updated this revision to Diff 12134.Jan 7 2019, 1:56 PM

Alphabetize builddeps.

abdulocracy marked an inline comment as done.Jan 7 2019, 1:57 PM
DataDrake requested changes to this revision.Jan 7 2019, 3:38 PM
DataDrake added inline comments.
pspec_x86_64.xml
23

Sorry, missed this before, should be in:

/usr/share/dbus-1/system.d
This revision now requires changes to proceed.Jan 7 2019, 3:38 PM
kyrios123 added inline comments.
package.yml
21

How about using tmpfiles for this ?

pspec_x86_64.xml
31

also --disable-static

der_eismann added inline comments.
package.yml
21

Also please make it shorter -> install -dm00644 (or are we not doing this anymore @kyrios123?)

abdulocracy updated this revision to Diff 12218.Jan 8 2019, 9:17 AM

Fix dbus_confdir, add gtk-doc as builddep.

abdulocracy marked 2 inline comments as done.Jan 8 2019, 9:18 AM
abdulocracy updated this revision to Diff 12219.Jan 8 2019, 9:25 AM

Disable static libs.

abdulocracy marked an inline comment as done.Jan 8 2019, 9:25 AM
abdulocracy added inline comments.Jan 8 2019, 12:46 PM
package.yml
21

Haven't used it before, what would the ownership of the directory look like (UID, GID)?

DataDrake added inline comments.Jan 8 2019, 2:58 PM
package.yml
21

Should just me install -d for directories. Directories should are 00755 by default and that is fine for packaging.

21

root : root

pspec_x86_64.xml
31

Nice catch.

abdulocracy updated this revision to Diff 12231.Jan 8 2019, 6:01 PM

Remove -m00644.

abdulocracy marked an inline comment as done.Jan 8 2019, 6:01 PM
abdulocracy updated this revision to Diff 12232.Jan 8 2019, 6:22 PM

Use tmpfiles.

abdulocracy marked 3 inline comments as done.Jan 8 2019, 6:22 PM
DataDrake accepted this revision.Jan 9 2019, 6:11 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 9 2019, 6:11 PM
This revision was automatically updated to reflect the committed changes.