Page MenuHomeSolus

Initial inclusion of fprintd
AcceptedPublic

Authored by abdulocracy on Tue, Jan 1, 4:35 PM.

Details

Summary

Inclusion of fprintd fixes T3574.

Test Plan

Install fprintd, enroll fingerprint, verify fingerprint.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
abdulocracy created this revision.Tue, Jan 1, 4:35 PM
abdulocracy requested review of this revision.Tue, Jan 1, 4:35 PM
Jacalz awarded a token.Tue, Jan 1, 5:30 PM
DataDrake requested changes to this revision.Mon, Jan 7, 1:09 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
12

Should be sorted alphabetically.

This revision now requires changes to proceed.Mon, Jan 7, 1:09 PM
abdulocracy updated this revision to Diff 12134.Mon, Jan 7, 1:56 PM

Alphabetize builddeps.

abdulocracy marked an inline comment as done.Mon, Jan 7, 1:57 PM
DataDrake requested changes to this revision.Mon, Jan 7, 3:38 PM
DataDrake added inline comments.
pspec_x86_64.xml
23

Sorry, missed this before, should be in:

/usr/share/dbus-1/system.d
This revision now requires changes to proceed.Mon, Jan 7, 3:38 PM
kyrios123 added inline comments.
package.yml
21

How about using tmpfiles for this ?

pspec_x86_64.xml
31

also --disable-static

der_eismann added inline comments.
package.yml
21

Also please make it shorter -> install -dm00644 (or are we not doing this anymore @kyrios123?)

abdulocracy updated this revision to Diff 12218.Tue, Jan 8, 9:17 AM

Fix dbus_confdir, add gtk-doc as builddep.

abdulocracy marked 2 inline comments as done.Tue, Jan 8, 9:18 AM
abdulocracy updated this revision to Diff 12219.Tue, Jan 8, 9:25 AM

Disable static libs.

abdulocracy marked an inline comment as done.Tue, Jan 8, 9:25 AM
abdulocracy added inline comments.Tue, Jan 8, 12:46 PM
package.yml
21

Haven't used it before, what would the ownership of the directory look like (UID, GID)?

DataDrake added inline comments.Tue, Jan 8, 2:58 PM
package.yml
21

Should just me install -d for directories. Directories should are 00755 by default and that is fine for packaging.

21

root : root

pspec_x86_64.xml
31

Nice catch.

abdulocracy updated this revision to Diff 12231.Tue, Jan 8, 6:01 PM

Remove -m00644.

abdulocracy marked an inline comment as done.Tue, Jan 8, 6:01 PM
abdulocracy updated this revision to Diff 12232.Tue, Jan 8, 6:22 PM

Use tmpfiles.

abdulocracy marked 3 inline comments as done.Tue, Jan 8, 6:22 PM
DataDrake accepted this revision.Wed, Jan 9, 6:11 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Wed, Jan 9, 6:11 PM