Page MenuHomeSolus

Initial inclusion of glava
ClosedPublic

Authored by abdulocracy on Dec 31 2018, 3:54 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T5982: Glava
Commits
R4644:ff9d950dc106: Initial inclusion of glava
Summary

Initial inclusion of glava, fixes T5982.

Test Plan

Run glava, play some music, make sure the visualization works.

Diff Detail

Repository
R4644 glava
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abdulocracy created this revision.Dec 31 2018, 3:54 PM
abdulocracy requested review of this revision.Dec 31 2018, 3:54 PM
Girtablulu added inline comments.
package.yml
7
14

No needed dependency of the other x

The the file install should be under /usr/share/glava/ and not inside /etc/

DataDrake requested changes to this revision.Dec 31 2018, 4:55 PM
This revision now requires changes to proceed.Dec 31 2018, 4:55 PM
abdulocracy updated this revision to Diff 11989.Jan 1 2019, 4:23 PM

Fix the shader install directory and suggested changes in package.yml.

abdulocracy marked 2 inline comments as done.Jan 1 2019, 4:23 PM
DataDrake accepted this revision.Jan 7 2019, 12:28 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 7 2019, 12:28 PM
This revision was automatically updated to reflect the committed changes.