Page MenuHomeSolus

Initial packaging for cryfs
ClosedPublic

Authored by clivejo on Dec 31 2018, 2:26 PM.

Details

Summary

Initial packaging for cryfs, fixes T5214

Test Plan

Used in conjunction with plasma-vault to provide encrypted virtual desktops

Diff Detail

Repository
R4646 cryfs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
clivejo created this revision.Dec 31 2018, 2:26 PM
clivejo requested review of this revision.Dec 31 2018, 2:26 PM
DataDrake requested changes to this revision.Dec 31 2018, 5:01 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
7

should be -only or -or-later

22

Should really be in the setup phase.

If there's nothing to do in build because it all happens in install, just omit it.

23

Any reason to override this? usually we want the debug build for debugging symbols.

pspec_x86_64.xml
23

These are getting put in the wrong folders.

This revision now requires changes to proceed.Dec 31 2018, 5:01 PM
clivejo updated this revision to Diff 12000.Jan 2 2019, 12:52 AM

Fixes per review

DataDrake requested changes to this revision.Jan 7 2019, 12:30 PM
DataDrake added inline comments.
package.yml
19

Guessing you don't actually need to do this for this build otherwise it would go before cmake and you would have to cd for build and install as well. Go ahead and omit it.

This revision now requires changes to proceed.Jan 7 2019, 12:30 PM
clivejo updated this revision to Diff 12185.Jan 8 2019, 12:03 AM

Removed setup as apparently it doesn't need this to build now!

DataDrake accepted this revision.Jan 8 2019, 4:11 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 8 2019, 4:11 AM
Closed by commit R4646:c49b148011fb: Initial packaging for cryfs (authored by Clive Johnston <clivejo@protonmail.com>, committed by DataDrake). · Explain WhyJan 8 2019, 4:18 AM
This revision was automatically updated to reflect the committed changes.