Update fish to 3.0
ClosedPublic
Actions

Authored by livingsilver94 on Dec 29 2018, 12:14 AM.

Details

Reviewers

JoshStrobl
DataDrake

Group Reviewers

Triage Team

Maniphest Tasks

T7409: Update fish to release 3.0

Commits

R759:ddcec1caae2d: Update fish to 3.0

Summary

Release notes available here.
Fixes T7409.

Test Plan

Unit tests passed. Successfully browsed inside /tmp and touched a file.
Successfully called a custom function defined in /etc/fish/functions.

Diff Detail

Repository

R759 fish

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

livingsilver94 created this revision.Dec 29 2018, 12:14 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 29 2018, 12:14 AM

livingsilver94 requested review of this revision.Dec 29 2018, 12:14 AM

livingsilver94 added a comment.Dec 29 2018, 12:21 AM

This comment was removed by livingsilver94.

Use git repository as souce (as this defines the version string to 3.0 instead of unknown)

livingsilver94 edited the summary of this revision. (Show Details)Dec 29 2018, 10:19 AM

livingsilver94 added a task: T7409: Update fish to release 3.0.

JoshStrobl requested changes to this revision.Dec 29 2018, 1:12 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

pspec_x86_64.xml
32–35	This needs to be fixed.

This revision now requires changes to proceed.Dec 29 2018, 1:12 PM

Yeah I suspected that.

chax added a subscriber: chax.Dec 29 2018, 2:26 PM

Move etc directory to root

livingsilver94 edited the test plan for this revision. (Show Details)Dec 30 2018, 10:15 AM

JoshStrobl added inline comments.Dec 30 2018, 1:49 PM

package.yml
27	I think their CMake files are just a bit foobar. Try doing `-DCMAKE_INSTALL_SYSCONFDIR=$installdir/etc` after the `%cmake_ninja` macro.

livingsilver94 added inline comments.Dec 30 2018, 1:54 PM

package.yml
27	It gets ever worse: `<Path fileType="data">/home/build/YPKG/root/fish/install/etc/fish/completions</Path>`

Not sure if I should abandon this patch as I don't use fish regularly.
Personally I don't agree with this policy, but I'll continue to contribute to packages I'm more involved with anyway.

Not sure if I should abandon this patch as I don't use fish regularly.
Personally I don't agree with this policy, but I'll continue to contribute to packages I'm more involved with anyway.

What are you on about? You're updating something in the repo that already exists, not asking for something new that you aren't even going to use.

[domenica 30 dicembre 2018] [19:44:02 CET] <DataDrake> we'd much rather you spent time updating and maintaining things you use daily

So is this an order or rather an advice?
To be clear: I'm not irritated, angry or whatever. I'm genuinely asking.

In D4873#77982, @livingsilver94 wrote:

[domenica 30 dicembre 2018] [19:44:02 CET] <DataDrake> we'd much rather you spent time updating and maintaining things you use daily

So is this an order or rather an advice?
To be clear: I'm not irritated, angry or whatever. I'm genuinely asking.

Advice? It is my opinion that maintainers do a better job at testing and integration when it is a piece of software they use on a regular basis. I was expressing an opinion not a demand. If you're testing things, submitting valid patches, and not getting complaints from users: I won't tell you how to spend your free time.

As for this patch: LGTM. Thanks!

livingsilver94 mentioned this in D4933: Update fish to 3.0.0.Jan 3 2019, 1:04 PM

I'm just wondering what's the status of this. Will this be merged/released soon?

This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2019, 3:43 AM

Closed by commit R759:ddcec1caae2d: Update fish to 3.0 (authored by livingsilver94, committed by DataDrake). · Explain Why

This revision was automatically updated to reflect the committed changes.