Page MenuHomeSolus
Differential D4865

Customise theme and icons
ClosedPublic
Actions

Authored by so-lo on Dec 28 2018, 7:16 PM.
Tags
None
Referenced Files
F11037945: D4865.id11917.diff
Wed, Aug 9, 9:31 PM
F11037944: D4865.id11897.diff
Wed, Aug 9, 9:31 PM
F11037943: D4865.id11916.diff
Wed, Aug 9, 9:31 PM
F11037942: D4865.id.diff
Wed, Aug 9, 9:31 PM
F11037940: D4865.id11909.diff
Wed, Aug 9, 9:30 PM
F11033967: D4865.diff
Wed, Aug 9, 4:20 PM
F11027344: D4865.diff
Wed, Aug 9, 4:03 AM
F11026371: D4865.id11917.diff
Wed, Aug 9, 2:14 AM
View All 18 Files
Subscribers
JoshStrobl
Tokens
"Yellow Medal" token, awarded by kyrios123.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T7395: Make gimp use system theme
Commits
R907:abd654bed91b: Customise theme and icons
Summary

This patches the gloabl gimprc file to achieve the following defaults

  • Use the system theme
  • Derive the icon size from the theme

Fixes T7395

Test Plan

Build the package and inspect /etc/gimp/2.0/gimprc

Diff Detail

Repository
R907 gimp
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

so-lo created this revision.Dec 28 2018, 7:16 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptDec 28 2018, 7:16 PM
so-lo requested review of this revision.Dec 28 2018, 7:16 PM
JoshStrobl requested changes to this revision.Dec 29 2018, 12:29 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
files/0001-Customise-theme-and-icons.patch
27–28

No, it should really stay with symbolic.

This revision now requires changes to proceed.Dec 29 2018, 12:29 AM
so-lo updated this revision to Diff 11909.Dec 29 2018, 7:32 AM

Remove icon theme change (stick with symbolic)

kyrios123 awarded a token.Dec 29 2018, 9:14 AM
JoshStrobl requested changes to this revision.Dec 29 2018, 1:24 PM
JoshStrobl added inline comments.
package.yml
46

Sorry, only just noticed this. Let's change the bug URL to https://dev.getsol.us - thanks!

This revision now requires changes to proceed.Dec 29 2018, 1:24 PM
so-lo updated this revision to Diff 11916.Dec 29 2018, 1:32 PM
so-lo marked an inline comment as done.

Fixed bug report URL to point to https://dev.getsol.us/

JoshStrobl accepted this revision.Dec 29 2018, 1:47 PM
JoshStrobl edited the summary of this revision. (Show Details)

LGTM, thank you for your contribution :)

This revision is now accepted and ready to land.Dec 29 2018, 1:47 PM
Closed by commit R907:abd654bed91b: Customise theme and icons (authored by so-lo, committed by JoshStrobl). · Explain WhyDec 29 2018, 1:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11897

View Options

files/0001-Customise-theme-and-icons.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.