Page MenuHomeSolus

Initial working on rustup
ClosedPublic

Authored by josephscade on Dec 24 2018, 5:27 PM.
Tags
None
Referenced Files
F11047130: D4821.id11762.diff
Thu, Aug 10, 2:50 PM
F11047129: D4821.id11860.diff
Thu, Aug 10, 2:50 PM
F11047128: D4821.id11870.diff
Thu, Aug 10, 2:50 PM
F11047127: D4821.id.diff
Thu, Aug 10, 2:50 PM
F11047126: D4821.id11871.diff
Thu, Aug 10, 2:50 PM
F11047125: D4821.id11869.diff
Thu, Aug 10, 2:50 PM
F11047124: D4821.id11859.diff
Thu, Aug 10, 2:50 PM
F11047123: D4821.id11862.diff
Thu, Aug 10, 2:50 PM

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T5309: rustup
Commits
R4626:7ccc300607a9: Initial working on rustup
Summary

Rustup has been accepted and is waiting for someone to provide patches. It's me :)
This is my first attempt to create a package, don't hesitate to comment my work.

Test Plan

Run rustup install stable as a regular user.
Add ~/.cargo/bin to $PATH
You should now be able to execute cargo and rustc.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

DataDrake added a task: T5309: rustup.
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
7

Should be programming.tools

This revision now requires changes to proceed.Dec 26 2018, 1:52 PM
Girtablulu added inline comments.
package.yml
12

Not needed is a dependency of cargo

josephscade marked an inline comment as done.

Removed useless dependencies

josephscade added inline comments.
package.yml
7

Fixed, thanks

12

Fixed, thanks

Merged build step and install step
For cargo, it's the same.

Asking for the sake of quality: is it good to skip build and do everything inside install with a command like cargo install --root=/blah?

You are right, this is not the cleanest way.
I'm working on it (compiling rustup and then moving it to the appropriate location)

The script now has a normal behavior. Thank you @livingsilver94

package.yml
19

Should be -Dm00755

Fixed binary file permissions. Thanks @Girtablulu

This revision is now accepted and ready to land.Dec 27 2018, 7:27 PM
This revision was automatically updated to reflect the committed changes.