Page MenuHomeSolus

Initial working on rustup
ClosedPublic

Authored by josephscade on Dec 24 2018, 5:27 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T5309: rustup
Commits
R4626:7ccc300607a9: Initial working on rustup
Summary

Rustup has been accepted and is waiting for someone to provide patches. It's me :)
This is my first attempt to create a package, don't hesitate to comment my work.

Test Plan

Run rustup install stable as a regular user.
Add ~/.cargo/bin to $PATH
You should now be able to execute cargo and rustc.

Diff Detail

Repository
R4626 rustup
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
josephscade created this revision.Dec 24 2018, 5:27 PM
josephscade requested review of this revision.Dec 24 2018, 5:27 PM
DataDrake requested changes to this revision.Dec 26 2018, 1:51 PM
DataDrake added a task: T5309: rustup.
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
8

Should be programming.tools

This revision now requires changes to proceed.Dec 26 2018, 1:52 PM
Girtablulu added inline comments.
package.yml
13

Not needed is a dependency of cargo

Fixed component. Thanks @DataDrake

josephscade marked an inline comment as done.

Removed useless dependencies

josephscade marked an inline comment as done.Dec 27 2018, 12:41 PM
josephscade added inline comments.
package.yml
8

Fixed, thanks

13

Fixed, thanks

josephscade marked 3 inline comments as done.Dec 27 2018, 12:42 PM

Merged build step and install step
For cargo, it's the same.

Asking for the sake of quality: is it good to skip build and do everything inside install with a command like cargo install --root=/blah?

You are right, this is not the cleanest way.
I'm working on it (compiling rustup and then moving it to the appropriate location)

The script now has a normal behavior. Thank you @livingsilver94

Girtablulu added inline comments.Dec 27 2018, 7:07 PM
package.yml
19

Should be -Dm00755

Fixed binary file permissions. Thanks @Girtablulu

josephscade marked an inline comment as done.Dec 27 2018, 7:22 PM

Fix license

DataDrake accepted this revision.Dec 27 2018, 7:27 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 27 2018, 7:27 PM
This revision was automatically updated to reflect the committed changes.