Page MenuHomeSolus

Inclusion of qt5-location-googlemaps
AbandonedPublic

Authored by flyingP0tat0 on Dec 24 2018, 12:11 PM.
Tags
None
Referenced Files
F10836025: D4811.diff
Jun 8 2023, 9:18 AM
F10828373: D4811.id11749.diff
Jun 4 2023, 9:13 AM
F10818341: D4811.diff
Jun 1 2023, 12:30 PM
F10726322: D4811.diff
May 9 2023, 3:21 AM
Subscribers

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

This is a Qt5Location plugin for using Google Maps' tile API.
It is an optional dependency of subsurface, requested per T6796.

Test Plan

Used the map inside subsurface with this dependency.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

DataDrake added a subscriber: DataDrake.

I'd like to hold off on this for a bit since it's first release ever was just two weeks ago. hold on to your package.yml and we can talk in a month or so if they've continued churning out releases.

@DataDrake To be honest, the release only happened only because I asked the author to create one.
The thing with this plugin is that it is more or less "done" and does not receive major changes. I would be fine with just leaving the plugin out and packaging subsurface without it.

Well, I definitely don't want it if it requires patching subsurface for it to be used. That's my bigger hang-up.

Yeah, it does not feel like a very clean way. On the other hand it is a drawback in terms of usability but I guess that won't hurt too much.