Page MenuHomeSolus

Inital pkg for android-tools
AbandonedPublic

Authored by mariogrip on Dec 23 2018, 10:23 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T7381: Package Request: android-tools
Summary

Inital pkg for android-tools, this includes adb and fastboot. fixes T7381

Test Plan

pkg functions and installs correctly

adb, connected to device functions as normal. shell, push, pull, devices functions as normal
fastboot, functions as normal, no udev rules so sudo is needed. flash and boot functions as normal

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
mariogrip created this revision.Dec 23 2018, 10:23 PM
mariogrip requested review of this revision.Dec 23 2018, 10:23 PM
mariogrip edited the test plan for this revision. (Show Details)Dec 23 2018, 10:41 PM
mariogrip updated this revision to Diff 11740.Dec 24 2018, 1:11 AM
  • Move to programming.tools
  • Update pspec to reflect package.yml
DataDrake requested changes to this revision.Dec 26 2018, 2:15 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
12

Should be using pkgconfig() directives for libraries with .pc files. See Provides in the eopkg info output for the required libs.

This revision now requires changes to proceed.Dec 26 2018, 2:15 PM
EvolutionMod requested changes to this revision.Jan 4 2019, 3:36 AM
EvolutionMod added a subscriber: EvolutionMod.
This comment was removed by EvolutionMod.

should be android-command-line-tools or something to that affect because its only adb and fastboot, not the entire android platform-tools

No. It should be android-tools to match upstream.

should be android-command-line-tools or something to that affect because its only adb and fastboot, not the entire android platform-tools

No. It should be android-tools to match upstream.

I just seen that, for some reason i was thinking it was bundled still.

I just seen that, for some reason i was thinking it was bundled still.

Probably because this is the ubports fork, not Google's.

I just seen that, for some reason i was thinking it was bundled still.

Probably because this is the ubports fork, not Google's.

Thanks @DataDrake

package.yml
13

zlib-devel is not needed as it's part of system.devel.

package.yml
14

Ditto for openssl-devel.

DataDrake abandoned this revision.Mar 30 2019, 8:14 PM

Closing due to lack of movement.