Page MenuHomeSolus

Inclusion of subsurface
ClosedPublic

Authored by flyingP0tat0 on Dec 23 2018, 10:18 PM.

Details

Summary

Depends on D4802

Subsurface was requested per T6796.

Test Plan

Used Subsurface to create and modify dives, imported data from dive computer via USB.

Diff Detail

Repository
R4628 subsurface
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
flyingP0tat0 created this revision.Dec 23 2018, 10:18 PM
flyingP0tat0 requested review of this revision.Dec 23 2018, 10:18 PM

Added qt5-location-googlemaps dependency and needed patch for the dependency to work.

DataDrake requested changes to this revision.Dec 26 2018, 2:03 PM
DataDrake added a subscriber: DataDrake.

Needs a rebuild without the googlemaps stuff. Let's wait until upstream officially supports it.

This revision now requires changes to proceed.Dec 26 2018, 2:03 PM

Removed qt5-location-googlemaps dependency

JoshStrobl requested changes to this revision.Dec 26 2018, 7:52 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
7–8

Firstly, we use SPDX 3.0 identifiers, as stated in our documentation. Secondly this can be on the same line, no reason for it to be a list.

10

No reason for the description to not also be the summary. Divelog program is too succinct.

22

Not necessary. This is a dependency on qt5-connectivity-devel, qt5-svg-devel, etc.

31–33

Can try just using -B build instead.

35–36

Can just use -C build instead of cd'ing first.

38–39

Can just use -C build instead of cd'ing first.

pspec_x86_64.xml
24

Is there a specific reason we need to enable debug for this?

This revision now requires changes to proceed.Dec 26 2018, 7:52 PM

Cleanup of package.yml

JoshStrobl accepted this revision.Dec 27 2018, 10:19 AM
DataDrake accepted this revision.Dec 27 2018, 7:32 PM
This revision is now accepted and ready to land.Dec 27 2018, 7:32 PM
This revision was automatically updated to reflect the committed changes.