Details
- Reviewers
DataDrake JoshStrobl - Group Reviewers
Triage Team - Commits
- R4628:c72aa1a601a5: Inclusion of subsurface
Used Subsurface to create and modify dives, imported data from dive computer via USB.
Diff Detail
- Repository
- R4628 subsurface
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Added qt5-location-googlemaps dependency and needed patch for the dependency to work.
Needs a rebuild without the googlemaps stuff. Let's wait until upstream officially supports it.
| package.yml | ||
|---|---|---|
| 7–8 | Firstly, we use SPDX 3.0 identifiers, as stated in our documentation. Secondly this can be on the same line, no reason for it to be a list. | |
| 10 | No reason for the description to not also be the summary. Divelog program is too succinct. | |
| 22 | Not necessary. This is a dependency on qt5-connectivity-devel, qt5-svg-devel, etc. | |
| 31–33 | Can try just using -B build instead. | |
| 35–36 | Can just use -C build instead of cd'ing first. | |
| 38–39 | Can just use -C build instead of cd'ing first. | |
| pspec_x86_64.xml | ||
| 24 | Is there a specific reason we need to enable debug for this? | |