Page MenuHomeSolus

Inclusion of subsurface-libdc
ClosedPublic

Authored by flyingP0tat0 on Dec 23 2018, 10:14 PM.
Tags
None
Referenced Files
F11038323: D4802.id.diff
Wed, Aug 9, 10:28 PM
F11038322: D4802.id11735.diff
Wed, Aug 9, 10:28 PM
F11038321: D4802.id11798.diff
Wed, Aug 9, 10:28 PM
F11038320: D4802.id11829.diff
Wed, Aug 9, 10:28 PM
F11038319: D4802.id11874.diff
Wed, Aug 9, 10:28 PM
F11027421: D4802.diff
Wed, Aug 9, 4:18 AM
F11012107: D4802.diff
Fri, Aug 4, 12:29 AM
F10897694: D4802.id.diff
Jul 2 2023, 9:01 AM

Details

Summary

This package is needed for subsurface as requested in T6796.
It is a branch of libdivecomputer specifically made for subsurface.
Libdivecomputer provides an interface to communicate with dive computers.

Test Plan

Used subsurface to import data from a Mares Puck Pro via USB.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
7

Needs to be a valid SPDX identifier. Which means either LGPL-2.1-only or LGPL-2.1-or-later as determined by the authors.

8

should be programming.library since it is just a lib.

This revision now requires changes to proceed.Dec 26 2018, 2:06 PM

Updated component to programming.library

This revision is now accepted and ready to land.Dec 26 2018, 2:25 PM
Staudey added inline comments.
pspec_x86_64.xml
101

Shouldn't it be "%reconfigure --disable-static" in the package.yml to get rid of this .a file?

JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
7–8

Does not need to be on a new line.

pspec_x86_64.xml
101

Yes.

This revision now requires changes to proceed.Dec 26 2018, 8:04 PM
This revision is now accepted and ready to land.Dec 27 2018, 10:17 AM
This revision was automatically updated to reflect the committed changes.