Page MenuHomeSolus

Inclusion of subsurface-libdc
ClosedPublic

Authored by flyingP0tat0 on Dec 23 2018, 10:14 PM.

Details

Summary

This package is needed for subsurface as requested in T6796.
It is a branch of libdivecomputer specifically made for subsurface.
Libdivecomputer provides an interface to communicate with dive computers.

Test Plan

Used subsurface to import data from a Mares Puck Pro via USB.

Diff Detail

Repository
R4627 subsurface-libdc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
flyingP0tat0 created this revision.Dec 23 2018, 10:14 PM
flyingP0tat0 requested review of this revision.Dec 23 2018, 10:14 PM
DataDrake requested changes to this revision.Dec 26 2018, 2:06 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
8

Needs to be a valid SPDX identifier. Which means either LGPL-2.1-only or LGPL-2.1-or-later as determined by the authors.

9

should be programming.library since it is just a lib.

This revision now requires changes to proceed.Dec 26 2018, 2:06 PM

Updated component to programming.library

DataDrake accepted this revision.Dec 26 2018, 2:25 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 26 2018, 2:25 PM
Staudey added inline comments.
pspec_x86_64.xml
101

Shouldn't it be "%reconfigure --disable-static" in the package.yml to get rid of this .a file?

JoshStrobl requested changes to this revision.Dec 26 2018, 8:04 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
7–8

Does not need to be on a new line.

pspec_x86_64.xml
101

Yes.

This revision now requires changes to proceed.Dec 26 2018, 8:04 PM

Disabled static library

JoshStrobl accepted this revision.Dec 27 2018, 10:17 AM
This revision is now accepted and ready to land.Dec 27 2018, 10:17 AM
This revision was automatically updated to reflect the committed changes.