Page MenuHomeSolus

Add Dolphin integration
ClosedPublic

Authored by livingsilver94 on Dec 22 2018, 12:32 PM.

Details

Summary

Add Dolphin integration.

Test Plan

All unit tests passed. Special icons and context menu entries are correctly shown and working. Plus, I've been using it for three weeks.
nextcloud-client alone works well without the extension.

Diff Detail

Repository
R3740 nextcloud-client
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 requested review of this revision.Dec 22 2018, 12:32 PM

I know there was a proposal to split KDE-related bits into a separate package. Let me know what you prefer.

livingsilver94 edited the test plan for this revision. (Show Details)Dec 22 2018, 12:33 PM
livingsilver94 edited the test plan for this revision. (Show Details)
JoshStrobl requested changes to this revision.Dec 22 2018, 12:36 PM
JoshStrobl added a subscriber: JoshStrobl.

The Dolphin specific stuff should get patterned out IMO (maybe -dolphin-integration), to prevent the unnecessary downloading of KDE deps for non-Plasma systems.

This revision now requires changes to proceed.Dec 22 2018, 12:36 PM

I know there was a proposal to split KDE-related bits into a separate package. Let me know what you prefer.

Timing++ :D

I know there was a proposal to split KDE-related bits into a separate package. Let me know what you prefer.

Timing++ :D

You gotta fix race conditions, man!

livingsilver94 retitled this revision from Add Dolphin integration to [RFC] Add Dolphin integration.Dec 22 2018, 2:41 PM

Can RFC it all you want but I already gave you my remarks that it needs to be patterned into a sub-package :P

livingsilver94 added a subscriber: DataDrake.EditedDec 22 2018, 5:52 PM

I RFC'd it as I'd spoken with @DataDrake on IRC and he's not sure whether to split the package or not. I don't know if have the veto right.

I wanted to update this patch with the dolphin-integration pattern implemented but I'm still getting this error with arcanist:

Exception
[cURL/92] (https://dev.getsol.us/api/differential.creatediff) The cURL library raised an error while making a request. You may be able to find more information about this error (error code: 92) on the cURL site: http://curl.haxx.se/libcurl/c/libcurl-errors.html#
(Run with --trace for a full exception trace.)

Full exception message:

[2018-12-22 21:13:18] EXCEPTION: (HTTPFutureCURLResponseStatus) [cURL/92] (https://dev.getsol.us/api/differential.creatediff) The cURL library raised an error while making a request. You may be able to find more information about this error (error code: 92) on the cURL site: http://curl.haxx.se/libcurl/c/libcurl-errors.html# at [<phutil>/src/future/http/HTTPSFuture.php:408]

arcanist(), phutil()
#0 HTTPSFuture::isReady() called at [<phutil>/src/future/Future.php:37]
#1 Future::resolve(NULL) called at [<phutil>/src/future/FutureProxy.php:34]
#2 FutureProxy::resolve() called at [<phutil>/src/conduit/ConduitClient.php:64]
#3 ConduitClient::callMethodSynchronous(string, array) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:519]
#4 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394]

Add pattern (uploaded via web interface).

livingsilver94 retitled this revision from [RFC] Add Dolphin integration to Add Dolphin integration.Dec 23 2018, 12:20 PM
livingsilver94 edited the test plan for this revision. (Show Details)
JoshStrobl accepted this revision.Dec 25 2018, 2:04 PM
This revision is now accepted and ready to land.Dec 25 2018, 2:04 PM
This revision was automatically updated to reflect the committed changes.