Page MenuHomeSolus

Update python-request to 2.21.0
ClosedPublic

Authored by Girtablulu on Dec 20 2018, 3:38 PM.

Details

Summary

Update python-request to 2.21.0 and added the test function. Changelog available here.

Test Plan

Tested it with lollypop virt-manager haste-it

Diff Detail

Repository
R2684 python-requests
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Dec 20 2018, 3:38 PM
Girtablulu requested review of this revision.Dec 20 2018, 3:38 PM
Girtablulu updated this revision to Diff 11635.Dec 20 2018, 3:42 PM
Girtablulu edited the summary of this revision. (Show Details)

Make Josh happy :3

JoshStrobl edited the summary of this revision. (Show Details)Dec 20 2018, 3:42 PM
Girtablulu updated this revision to Diff 11637.Dec 20 2018, 3:52 PM
Girtablulu edited the test plan for this revision. (Show Details)

Add more test software

JoshStrobl accepted this revision.Dec 20 2018, 3:58 PM
This revision is now accepted and ready to land.Dec 20 2018, 3:58 PM
This revision was automatically updated to reflect the committed changes.

@Girtablulu Unfortunately this update broke docker-compose. Docker Compose has the following requirement for the requests package: 'requests!=2.11.0,!=2.12.2,!=2.18.0,<2.21,>=2.6.1'

kyrios123 added a subscriber: kyrios123.

@Girtablulu Unfortunately this update broke docker-compose. Docker Compose has the following requirement for the requests package: 'requests!=2.11.0,!=2.12.2,!=2.18.0,<2.21,>=2.6.1'

I did patch docker-compose to tell it to shut up about requests version (D4782).
Please next time create a task to report an issue instead of commenting patch so we can do proper tracking and follow up.