Page MenuHomeSolus

Updated plymouth package to 0.9.4
Needs ReviewPublic

Authored by ZachBacon on Dec 15 2018, 4:55 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Test Plan

Make sure all changes work with included login display managers and try and get it working with most display drivers that support kms
Most of the leg work for updating is finished, it should now play nicely with dracut whenever the initrd is generated.
Also finish up custom solus splash.
Will be needing testers for those that use amd graphics if possible.

Diff Detail

Repository
R2456 plymouth
Branch
arcpatch-D4689
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

ZachBacon created this revision.Dec 15 2018, 4:55 PM
ZachBacon requested review of this revision.Dec 15 2018, 4:55 PM
ZachBacon updated this revision to Diff 11454.Dec 15 2018, 5:20 PM
  • The actual needed service files for seemless lightdm for uefi systems
  • Service files required added, will be adding the install routines soon.
ZachBacon updated this revision to Diff 11455.Dec 15 2018, 5:50 PM
  • Updated plymouth package.yml with the proper service modules
DataDrake abandoned this revision.Dec 17 2018, 1:39 AM
DataDrake added a subscriber: DataDrake.

Not sure why I didn't think to add it to the list already, but we have no plans of reintroducing plymouth. Even with the flicker free stuff, it still adds too much time to the boot process.

So I'm going to say this, there are some use cases for keeping it. I'm not saying using it by default but there are some use cases for those that do want it.
My laptop for instance. Piece of garbage that it is, while uses UEFI is also a very slow boot process. I've been toying with using it there. And I'm sure others wouldn't mind toying with it too if they so choose. Please keep this.

@DataDrake It isn't about re-introducing it, it's already in the repository. While I agree we'll never have it in the ISO / pre-installed, I don't see that as a reason to disallow it outright. The point in nuking stuff from the repo is things which are not maintained, are not feasible to maintain, are libraries which no longer have a respective reverse dependency, etc. Or we'd surely go down the route of nuking lightdm-settings, because there'd be no reason for someone to want to customize LightDM and not use our defaults, right? πŸ˜‰ If @ZachBacon is willing to maintain, thoroughly test this across all editions / desktop experiences (since a failed start of the service will likely result in failing to ever get to your login manager) and ensure updates are done in a timely manner, I'm sure this is something that can remain in the repo.

None really needed

Factually incorrect. A test plan is always needed. You would need to enable the services, validate it across LightDM, KDM, GDM, etc.

There's also no summary.

I would be willing to test among the different environments. In fact I've even been testing out a simple solus theme for Plymouth to use as a potential default when users install the package. But there's a lot more to test I'll admit than I initially put in. For now package is updated and it does work, but the flicker free experience I'm still trying to fine tune.

None really needed

Factually incorrect. A test plan is always needed. You would need to enable the services, validate it across LightDM, KDM, GDM, etc.
There's also no summary.

At the time before I started adding the custom service files there kinda was no testing required. That was at that time. I'm still not quite done with this until a certain someone actioned this as abandoned. I wasn't going to touch it until it was given the ok to continue what I started.

ZachBacon reclaimed this revision.Dec 22 2018, 11:44 PM

as per Josh and Bryan, reclaiming this and will be extending things as well as some new test cases

ZachBacon updated this revision to Diff 11742.Dec 24 2018, 3:24 AM
  • dracut can't find plymouth-initrd because it's looking for it in /usr/lib/ and not /usr/lib/plymouth.
ZachBacon updated this revision to Diff 11743.Dec 24 2018, 3:30 AM
ZachBacon edited the test plan for this revision. (Show Details)

Added test plan

ZachBacon updated this revision to Diff 15301.May 19 2019, 9:01 PM
  • Added the startup script
  • Forgot to include the package.yml changes
  • Add default config, it's not quite working on nvidia binary drivers just yet though
  • forgot the abi report and pspec