Page MenuHomeSolus

Initial commit of Anki
ClosedPublic

Authored by Staudey on Dec 11 2018, 6:09 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T286: Anki
Commits
R4607:91812f11360a: Initial commit of Anki
Summary

Initial commit of Anki
Resolves T286

Test Plan

Installed, downloaded a few decks for Japanese, tested the cards

Diff Detail

Repository
R4607 anki
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Dec 11 2018, 6:09 PM
Staudey requested review of this revision.Dec 11 2018, 6:09 PM
JoshStrobl requested changes to this revision.Dec 11 2018, 9:24 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
17

Should go above mpv

This revision now requires changes to proceed.Dec 11 2018, 9:24 PM
Staudey updated this revision to Diff 11383.Dec 11 2018, 9:32 PM

Fix dependency order

Staudey marked an inline comment as done.Dec 11 2018, 9:34 PM
Staudey added inline comments.
package.yml
17

Like this? So A-Z before a-z; or did I misunderstand?

JoshStrobl accepted this revision.Dec 11 2018, 9:35 PM
JoshStrobl added inline comments.
package.yml
17

Yep: 0-9A-Za-z, which pkgconfigs before explicitly listed ones (like python-decorator). We'll have linting tools at some point that'll raise this =)

This revision is now accepted and ready to land.Dec 11 2018, 9:35 PM
This revision was automatically updated to reflect the committed changes.