Page MenuHomeSolus
Differential D45

Update presentproto to 1.1
ClosedPublic
Actions

Authored by kyrios123 on May 7 2017, 5:09 PM.
Tags
None
Referenced Files
F11047708: D45.id73.diff
Thu, Aug 10, 3:45 PM
F11047707: D45.id.diff
Thu, Aug 10, 3:45 PM
F11047706: D45.id71.diff
Thu, Aug 10, 3:45 PM
F11047705: D45.id66.diff
Thu, Aug 10, 3:45 PM
F11047704: D45.id62.diff
Thu, Aug 10, 3:45 PM
F11033306: D45.diff
Wed, Aug 9, 3:31 PM
F10875664: D45.id66.diff
Jun 20 2023, 6:53 AM
Subscribers
JoshStrobl
kyrios123

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T3529: presentproto 1.1
Commits
R2479:873980da1cdc: Update presentproto to 1.1
Summary

Ref task T3529

Diff Detail

Repository
R2479 presentproto
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kyrios123 created this revision.May 7 2017, 5:09 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptMay 7 2017, 5:09 PM
JoshStrobl requested changes to this revision.May 7 2017, 5:17 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
6

Should be MIT not -MIT

This revision now requires changes to proceed.May 7 2017, 5:17 PM
kyrios123 updated this revision to Diff 66.May 7 2017, 5:23 PM
kyrios123 edited edge metadata.

Add missing space in licenses list

JoshStrobl added a comment.EditedMay 7 2017, 5:40 PM

That still doesn't fix the issue. The - should be removed, wasn't anything to do with the space. The pspec should be rebuilt to have the updated license too. You either specify the license as license : MIT or:

license  :
  - MIT
kyrios123 updated this revision to Diff 69.EditedMay 7 2017, 5:46 PM

fix package.yml (license)

Sorry @JoshStrobl I am not a good multitasker. :p

JoshStrobl added a comment.May 7 2017, 5:58 PM

You added the eopkg. That needs to be removed.

kyrios123 updated this revision to Diff 71.May 7 2017, 6:02 PM

remove .eopkg files (sorry... @JoshStrobl, I hope this time is to good one!)

JoshStrobl accepted this revision.May 7 2017, 6:04 PM

LGTM, thanks :)

This revision is now accepted and ready to land.May 7 2017, 6:04 PM
Closed by commit R2479:873980da1cdc: Update presentproto to 1.1 (authored by kyrios123, committed by JoshStrobl). · Explain WhyMay 7 2017, 6:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
21 lines
16 lines

Diff 73

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.