Page MenuHomeSolus

Update sfml to 2.5.1
ClosedPublic

Authored by kyrios123 on Thu, Dec 6, 10:30 AM.

Details

Summary
  • Window
    • Fixed dual monitor issue
    • Fixed the Unix clipboard implementation causing an abort due to internal data races in Xlib
  • Graphics
    • Fixed a bug in which a sf::RenderTexture would not be re-activated after being re-created
    • Fixed sf::RenderTextureImplFBO's destructor incorrectly triggering deletion of other sf::RenderTextureImplFBO's active FBOs
    • Fix sf::RenderWindow::setActive incorrectly trying to unbind an FBO during deactivation
    • Fixed sf::RenderTexture::display() dereferencing a NULL pointer when being called before sf::RenderTexture::create()
    • Fixed bug in sf::Text when applying an outline color/thickness
    • Squash duplicated sf::Font glyphs to single chars
    • Fixed two issues with glyph sub-pixel positioning
    • Reduced context locking & unlocking while creating textures
    • Fixed the error message when the wrong bitmap font size is selected
  • Audio
    • Fixed performance issue with reading WAV files

Resolves T7291

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • Play a little to cendric
  • Checked 2 gbc roms with visualboyadvance-m

Diff Detail

Repository
R3344 sfml
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kyrios123 created this revision.Thu, Dec 6, 10:30 AM
kyrios123 requested review of this revision.Thu, Dec 6, 10:30 AM
kyrios123 edited the summary of this revision. (Show Details)Thu, Dec 6, 10:31 AM
JoshStrobl requested changes to this revision.Thu, Dec 6, 11:09 PM
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added subscribers: ZachBacon, JoshStrobl.

Fixed issue where fullscreen window didn't go over task bars on top and left on in Ubuntu

Not relevant, was removed. I'd also encourage you to use one-space nested Markdown lists in the future, for stuff like "Window", that should be a first-level list item, others second, etc.

Also, your test plan is lacking. Should be tested against other applications, such as emulators. Bringing in @ZachBacon since he's the dev for VisualBoyAdvance-M on what the best way to test it would be.

This revision now requires changes to proceed.Thu, Dec 6, 11:11 PM
kyrios123 requested review of this revision.Sat, Dec 8, 3:19 PM
kyrios123 edited the test plan for this revision. (Show Details)
DataDrake accepted this revision.Tue, Dec 11, 3:34 AM
DataDrake added a project: Requires Rebuilds.
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

JoshStrobl accepted this revision.Tue, Dec 11, 3:54 AM
This revision is now accepted and ready to land.Tue, Dec 11, 3:54 AM
This revision was automatically updated to reflect the committed changes.