Page MenuHomeSolus

Update deepin-icon-theme to 15.12.66
ClosedPublic

Authored by kyrios123 on Wed, Dec 5, 8:24 PM.

Details

Summary
  • update some trayicons
  • update shutdown icons and fix
  • update action icons
  • finished Mimetype ,Places and Devices icons
  • add a new dark theme

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Checked the 3 icon sets & the cursors under Budgie
Note: the volume icon is too big and causes the task bar to look kinda weird

Diff Detail

Repository
R4353 deepin-icon-theme
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kyrios123 created this revision.Wed, Dec 5, 8:24 PM
kyrios123 requested review of this revision.Wed, Dec 5, 8:24 PM
kyrios123 edited the test plan for this revision. (Show Details)Wed, Dec 5, 8:34 PM

Do the -sea and -dark require the standard theme? If so, ensure those are rundeps.

Do the -sea and -dark require the standard theme? If so, ensure those are rundeps.

What do you mean by the standard theme? deepin "main" theme -> yeah if the user want the cursors, (s)he must install it since it was not split into a separate package or hicolor ? I don't think it requires it as it's anyway the fallback in case nothing else is found or papirus ? Yeah it requires it but since it's on the base image and it can't be uninstalled without removing the branding material (unless using --ignore-dependency), I thought it wasn't required.

I feel kinda stupid, but could you please advise on what you expect ?

Do the -sea and -dark require the standard theme? If so, ensure those are rundeps.

What do you mean by the standard theme? deepin "main" theme -> yeah if the user want the cursors, (s)he must install it since it was not split into a separate package or hicolor ? I don't think it requires it as it's anyway the fallback in case nothing else is found or papirus ? Yeah it requires it but since it's on the base image and it can't be uninstalled without removing the branding material (unless using --ignore-dependency), I thought it wasn't required.

I feel kinda stupid, but could you please advise on what you expect ?

Basically: Does -sea and -dark have Inherits that reference the standard Deepin theme. If it does, the standard theme needs to be a rundep of the other subpackages. Papirus is not relevant here.

Basically: Does -sea and -dark have Inherits that reference the standard Deepin theme. If it does, the standard theme needs to be a rundep of the other subpackages. Papirus is not relevant here.

Then it's fine as it is (I installed first dark & Sea, tested them then added the standard deeping and re-tested and I didn't notice a difference).

Basically: Does -sea and -dark have Inherits that reference the standard Deepin theme. If it does, the standard theme needs to be a rundep of the other subpackages. Papirus is not relevant here.

Then it's fine as it is (I installed first dark & Sea, tested them then added the standard deeping and re-tested and I didn't notice a difference).

Deepin: ~6600 icons
Deepin-dark: ~5000 icons
Sea: ~1000 icons

Inherits=deepin,Papirus (for both)

So they do depend on deepin to complete their sets.

Inherits=deepin,Papirus (for both)

So they do depend on deepin to complete their sets.

Thanks, I learned something today thanks to you.

PS; Do you think the volume icon size problem in the taskbar is related to Budgie ?

kyrios123 updated this revision to Diff 11220.Fri, Dec 7, 1:35 PM

Add missing runtime dependencies

Latest version is now 15.12.67

DataDrake accepted this revision.Tue, Dec 11, 2:24 AM
DataDrake added a subscriber: DataDrake.

LGTM. thanks!

This revision is now accepted and ready to land.Tue, Dec 11, 2:24 AM
This revision was automatically updated to reflect the committed changes.