Page MenuHomeSolus

Initial commit of libnvidia-container
AcceptedPublic

Authored by xulongwu4 on Sat, Dec 1, 11:02 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Summary

Initial commit of libnvidia-container

Test Plan

Dependency of D4518.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
xulongwu4 created this revision.Sat, Dec 1, 11:02 PM
xulongwu4 requested review of this revision.Sat, Dec 1, 11:02 PM
xulongwu4 edited the test plan for this revision. (Show Details)Sat, Dec 1, 11:07 PM
xulongwu4 updated this revision to Diff 11075.Sun, Dec 2, 5:19 AM
  • Set ccache to no so that we don't need to explicitly set CC during build
  • Move the executable out of the library package
xulongwu4 updated this revision to Diff 11317.Tue, Dec 11, 1:51 AM

Fix white spaces

  • Move the executable out of the library package

Does this really need separate packages? How big are the files?

  • Move the executable out of the library package

Does this really need separate packages? How big are the files?

The file is pretty small (tens of kB). I split it since this is an executable and it might not be appropriate in a library package.

xulongwu4 updated this revision to Diff 11341.Tue, Dec 11, 3:32 AM

Move the executable into main package

DataDrake accepted this revision.Tue, Dec 11, 4:25 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Tue, Dec 11, 4:25 AM