Page MenuHomeSolus

Initial commit of libnvidia-container
ClosedPublic

Authored by xulongwu4 on Dec 1 2018, 11:02 PM.

Details

Summary

Initial commit of libnvidia-container

Test Plan

Dependency of D4518.

Diff Detail

Repository
R4611 libnvidia-container
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
xulongwu4 created this revision.Dec 1 2018, 11:02 PM
xulongwu4 requested review of this revision.Dec 1 2018, 11:02 PM
xulongwu4 edited the test plan for this revision. (Show Details)Dec 1 2018, 11:07 PM
xulongwu4 updated this revision to Diff 11075.Dec 2 2018, 5:19 AM
  • Set ccache to no so that we don't need to explicitly set CC during build
  • Move the executable out of the library package
xulongwu4 updated this revision to Diff 11317.Dec 11 2018, 1:51 AM

Fix white spaces

  • Move the executable out of the library package

Does this really need separate packages? How big are the files?

  • Move the executable out of the library package

Does this really need separate packages? How big are the files?

The file is pretty small (tens of kB). I split it since this is an executable and it might not be appropriate in a library package.

xulongwu4 updated this revision to Diff 11341.Dec 11 2018, 3:32 AM

Move the executable into main package

DataDrake accepted this revision.Dec 11 2018, 4:25 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 11 2018, 4:25 AM
This revision was automatically updated to reflect the committed changes.