Differential D4519

Initial commit of nvidia-container-runtime
ClosedPublic
Actions

Authored by xulongwu4 on Dec 1 2018, 10:58 PM.

Tags

None

Subscribers

DataDrake, sunnyflunk

Details

Reviewers

Group Reviewers

Commits

R4612:c7b12578b11d: Initial commit of nvidia-container-runtime

Summary

Initial commit of nvidia-container-runtime

Test Plan

Dependency of D4518.

Diff Detail

Repository

R4612 nvidia-container-runtime

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

xulongwu4 created this revision.Dec 1 2018, 10:58 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 1 2018, 10:58 PM

xulongwu4 requested review of this revision.Dec 1 2018, 10:58 PM

xulongwu4 edited the test plan for this revision. (Show Details)Dec 1 2018, 11:06 PM

xulongwu4 edited the test plan for this revision. (Show Details)

xulongwu4 added a child revision: D4518: Initial commit of nvidia-docker. Resolves T3641..Dec 1 2018, 11:14 PM

Update rundeps based on new package.yml of libnvidia-container

Fix white spaces

sunnyflunk added a subscriber: sunnyflunk.Dec 11 2018, 2:01 AM

sunnyflunk added inline comments.

package.yml
21	Do we need these to be separate packages? They seem to depends on each other and pull in all the split packages so what is the point?

xulongwu4 added inline comments.Dec 11 2018, 2:05 AM

package.yml
21	The split of the package is based on what's been done in the deb and rpm file published by nvidia. Besides that, I don't think there are other reasons. Do you think it is better to keep them together in one package?

Merge the nvidia-container-runtime-hook subpackage into the main package

xulongwu4 marked an inline comment as done.Dec 11 2018, 3:36 AM

LGTM. thanks!

This revision is now accepted and ready to land.Dec 11 2018, 4:25 AM

Closed by commit R4612:c7b12578b11d: Initial commit of nvidia-container-runtime (authored by xulongwu4, committed by DataDrake). · Explain WhyDec 17 2018, 2:55 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		Makefile (1 line)
A	M		abi_used_libs (4 lines)
A	M		package.yml (36 lines)
A	M		pspec_x86_64.xml (34 lines)

Diff 11511

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...