Page MenuHomeSolus

Initial commit of nvidia-container-runtime
ClosedPublic

Authored by xulongwu4 on Dec 1 2018, 10:58 PM.

Details

Summary

Initial commit of nvidia-container-runtime

Test Plan

Dependency of D4518.

Diff Detail

Repository
R4612 nvidia-container-runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
xulongwu4 created this revision.Dec 1 2018, 10:58 PM
xulongwu4 requested review of this revision.Dec 1 2018, 10:58 PM
xulongwu4 edited the test plan for this revision. (Show Details)Dec 1 2018, 11:06 PM
xulongwu4 edited the test plan for this revision. (Show Details)
xulongwu4 updated this revision to Diff 11074.Dec 2 2018, 5:16 AM

Update rundeps based on new package.yml of libnvidia-container

xulongwu4 updated this revision to Diff 11315.Dec 11 2018, 1:50 AM

Fix white spaces

sunnyflunk added inline comments.
package.yml
21

Do we need these to be separate packages? They seem to depends on each other and pull in all the split packages so what is the point?

xulongwu4 added inline comments.Dec 11 2018, 2:05 AM
package.yml
21

The split of the package is based on what's been done in the deb and rpm file published by nvidia. Besides that, I don't think there are other reasons. Do you think it is better to keep them together in one package?

xulongwu4 updated this revision to Diff 11342.Dec 11 2018, 3:34 AM

Merge the nvidia-container-runtime-hook subpackage into the main package

xulongwu4 marked an inline comment as done.Dec 11 2018, 3:36 AM
DataDrake accepted this revision.Dec 11 2018, 4:25 AM
DataDrake added a subscriber: DataDrake.

LGTM. thanks!

This revision is now accepted and ready to land.Dec 11 2018, 4:25 AM
This revision was automatically updated to reflect the committed changes.