Page MenuHomeSolus

Initial commit of flashrom
ClosedPublic

Authored by davidjharder on Nov 29 2018, 2:27 AM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T6755: flashrom
Commits
R4603:994f7f21d91a: Initial commit of flashrom
Summary

Initial commit of flashrom. Resolves T6755.

Test Plan
  • check for man page: man flashrom
  • emulate a dummy chip, read its contents to a file: flashrom -p dummy:emulate=SST25VF032B, -r ~/Desktop/test.txt
  • erase the dummy chip: flashrom -p dummy:emulate=SST25VF032B, -E
  • try to write the file back onto the dummy chip: flashrom -p dummy:emulate=SST25VF032B, -r ~/Desktop/test.txt

Diff Detail

Repository
R4603 flashrom
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidjharder created this revision.Nov 29 2018, 2:27 AM
davidjharder requested review of this revision.Nov 29 2018, 2:27 AM
davidjharder edited the test plan for this revision. (Show Details)

Fix typo in test plan.

sunnyflunk added inline comments.
abi_used_libs
5

Is there need for this to be built against both versions of libusb?

davidjharder added inline comments.Dec 3 2018, 4:21 AM
abi_used_libs
5

I think this is because flashrom uses libusb 0.1 and Solus provides libusb 1.0 plus a compatibility layer.

Fix patch filename

Actually fix patch filename. Remove garbage added by previous edit.

davidjharder abandoned this revision.Dec 5 2018, 9:36 PM
davidjharder reclaimed this revision.Dec 7 2018, 12:18 AM
davidjharder updated this revision to Diff 11213.EditedDec 7 2018, 1:05 AM

Add Makefile, pspec.xml, abi_used_libs. Remove zlib builddep.

Apologies to Josh for the mess.

DataDrake accepted this revision.Dec 11 2018, 3:14 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 11 2018, 3:14 AM
This revision was automatically updated to reflect the committed changes.