Page MenuHomeSolus

Update sc-controller to 0.4.5 and fixup the package
ClosedPublic

Authored by Jacalz on Tue, Nov 27, 6:14 PM.

Details

Summary

This updates sc-controller from 0.4.3 to 0.4.5 with a couple changes and fixes:

  • Release notes for 0.4.5 can be found here
  • Release notes for 0.4.4 can be found here

Packaging changes:

  • Added build dependency on python-pylibacl, it is recommended and said to improve on how /dev/uinput access is handled.
  • Disabled stripping to not remove some important files for uinput, this fixes controller emulation!
  • Updated the summary and description with more relevant and up to data information.
Test Plan
  • Connected my chinese knock off Xbox 360 wireless adapter and made a profile for it. To be quite honest, I am suprised that Linux supports this one, even windows itself has some issues with trying to get it working...

Diff Detail

Repository
R2854 sc-controller
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jacalz created this revision.Tue, Nov 27, 6:14 PM
Jacalz requested review of this revision.Tue, Nov 27, 6:14 PM
Jacalz updated this revision to Diff 10984.Tue, Nov 27, 6:33 PM
  • Apply patch for setting wrong parent window in action editor
Jacalz edited the summary of this revision. (Show Details)Tue, Nov 27, 6:33 PM
Jacalz added a comment.EditedTue, Nov 27, 8:03 PM

Actually, wait with merging this, seems like Xbox 360 controllers explicitly are not supported officially. Mine did work, but apparently it’s not 100% supported. Going to make sure to update the description and summary tomorrow.

Disabled stripping to not remove some important files for uinput.

Can you elaborate on why strip is required

seems like Xbox 360 controllers explicitly are not supported officially

Does the current repo version officially support those controllers?

package.yml
5–6

GPL-2.0-only and needs rebuild

19

The : need to align.

strip : no

Jacalz added a comment.EditedWed, Nov 28, 8:49 AM

The program was spewing errors about uinput not being set up correctly and this the emulation was half borked. When I built the program I saw that it splitter out files related to uinput. Setting it to not split seemed to fix that issue for me.

The current repo version does support the DS4 controllers and some SNES like controllers as well as some custom controllers. But the new updated version does have better support for DS4 controllers over Bluetooth etc.

Jacalz updated this revision to Diff 11000.Wed, Nov 28, 6:09 PM
  • Fixes the summary and description as well as the review comments
Jacalz edited the summary of this revision. (Show Details)Wed, Nov 28, 6:11 PM
Jacalz marked 2 inline comments as done.

Review comments should be fixed now :)

In D4475#71513, @Jacalz wrote:

Actually, wait with merging this

Are happy with this now?

In D4475#71513, @Jacalz wrote:

Actually, wait with merging this

Are happy with this now?

Yes, this should be fine to merge now 👍

patch is an empty file just fyi

That is weird and I hadn't noticed it, will see to get that fixed later today

Jacalz updated this revision to Diff 11034.Thu, Nov 29, 6:47 PM
  • Make patch file actually do something
  • Remove patch since build errors with it
Jacalz edited the summary of this revision. (Show Details)Thu, Nov 29, 6:48 PM

Should be fine now

sunnyflunk accepted this revision.Sun, Dec 2, 11:55 PM
This revision is now accepted and ready to land.Sun, Dec 2, 11:55 PM
This revision was automatically updated to reflect the committed changes.