Page MenuHomeSolus

Initial commit of nnn
ClosedPublic

Authored by davidjharder on Mon, Nov 26, 7:57 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T7244: nnn
Commits
R4586:18315702787a: Initial commit of nnn
Summary

Initial commit of nnn. Resolves T7244.

Test Plan
  • Start nnn, try the following:
  • check version with ?
  • create a file
  • move file
  • rename file
  • delete file

Diff Detail

Repository
R4586 nnn
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidjharder created this revision.Mon, Nov 26, 7:57 PM
davidjharder requested review of this revision.Mon, Nov 26, 7:57 PM
davidjharder edited the summary of this revision. (Show Details)
davidjharder added a task: T7244: nnn.

Added reference to task.

This comment was removed by kyrios123.
JoshStrobl requested changes to this revision.Tue, Nov 27, 4:59 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8

Not a valid component. Should be system.utils.

pspec_x86_64.xml
23–24

/usr/local is not an accepted directory, needs to be /usr. Make sure to pass PREFIX=/usr during the %make_install

This revision now requires changes to proceed.Tue, Nov 27, 4:59 PM
  • fix component
  • pass proper directory to make_install
davidjharder marked 2 inline comments as done.Tue, Nov 27, 6:34 PM
kyrios123 added inline comments.Tue, Nov 27, 6:48 PM
package.yml
18

You can nuke the blank lines

Remove blank lines.

davidjharder marked an inline comment as done.Tue, Nov 27, 6:52 PM
JoshStrobl accepted this revision.Tue, Nov 27, 6:52 PM

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Nov 27, 6:52 PM
This revision was automatically updated to reflect the committed changes.