Differential D446

Update gwyddion to current stable version 2.48
ClosedPublic
Actions

Authored by remalhaut on Jun 20 2017, 9:27 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R1128:f15080dd96e9: Update gwyddion to current stable version 2.48

Summary

Updates the gwyddion package to the latest stable version (2.48). No major changes to dependencies, but please note I changed the component from multimedia.graphics to office.scientific

Diff Detail

Repository

R1128 gwyddion

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

remalhaut created this revision.Jun 20 2017, 9:27 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 20 2017, 9:27 PM

remalhaut edited the summary of this revision. (Show Details)Jun 21 2017, 2:19 PM

JoshStrobl requested changes to this revision.Jun 24 2017, 4:59 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
11	Newline should be removed.
11–24	builddeps should be cleaned up while we're updating it. Lots of dependencies here are deps of other bits or part of system.devel

This revision now requires changes to proceed.Jun 24 2017, 4:59 PM

Changes to package.yml:

Line 11: newline removed
Builddeps: Various unnecessary deps removed, list sorted alphabetically

(thanks JoshStrobl)
Packages build and install without a hitch and I haven't found issues with the application so far.

JoshStrobl requested changes to this revision.Jun 24 2017, 6:59 PM

JoshStrobl added inline comments.

package.yml
2–3	Trailing whitespace should be removed.
7	Should be using a mirror URL like freefr.dl.sourceforge.net IIRC
8	Trailing whitespace should be removed.
10	No need for 8 spaces. 4 is fine.