Page MenuHomeSolus

Initial commit of mindforger. Resolves T7161
ClosedPublic

Authored by xulongwu4 on Sun, Nov 25, 10:24 PM.

Details

Summary

Initial commit of mindforger. Resolves T7161.

Test Plan

Used it to open several markdown files.

Diff Detail

Repository
R4596 mindforger
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
xulongwu4 created this revision.Sun, Nov 25, 10:24 PM
xulongwu4 requested review of this revision.Sun, Nov 25, 10:24 PM

Are you willing to become the maintainer of this package?

Are you willing to become the maintainer of this package?

Yes I am happy to be the maintainer.

JoshStrobl added inline comments.
package.yml
22–30

What are you trying to do here exactly? Get the path and URL from .gitmodules and just add it again?

If this needs git submodules, you should just be using our git support, it automatically clones / performs the submodule init.

xulongwu4 updated this revision to Diff 10987.Tue, Nov 27, 9:03 PM

Use solbuild git support for initializing git submodules

xulongwu4 marked an inline comment as done.Tue, Nov 27, 9:06 PM
xulongwu4 added inline comments.
package.yml
22–30

Thanks @JoshStrobl. I didn't know about the git support. I have updated the package.yml file accordingly.

xulongwu4 updated this revision to Diff 11073.Sun, Dec 2, 4:48 AM
xulongwu4 marked an inline comment as done.

Remove ccache from the builddeps

JoshStrobl added inline comments.Thu, Dec 6, 10:02 PM
package.yml
28–29

Is this regarding deps/discount? I checked their configure.sh (non-standard from Autotools, yay /s) and it has a --shared option to enable shared libs instead of static, which is the default.

xulongwu4 added inline comments.Thu, Dec 6, 10:12 PM
package.yml
28–29

Yes this is for deps/discount. The author of this repo uses his own fork of discount and the configure.sh file is here: https://github.com/dvorka/discount/blob/50ad85cd324e56d003d7c870bdb250cfc860c717/configure.sh

I didn't want to used the shared library for this since discount-devel is already in our repo and I don't want that to conflict with that. Thus I kept it static during build and deleted it afterwards. What do you think is the best practice for this @JoshStrobl ?

JoshStrobl accepted this revision.Thu, Dec 6, 11:22 PM
JoshStrobl added inline comments.
package.yml
28–29

Gotcha. Wasn't immediately clear from the comment as to the reasoning.

This revision is now accepted and ready to land.Thu, Dec 6, 11:22 PM
This revision was automatically updated to reflect the committed changes.