Page MenuHomeSolus

Update etcher to 1.4.8
ClosedPublic

Authored by kyrios123 on Nov 25 2018, 1:52 AM.

Details

Summary

Features

  • Added featured-project while flashing

Fixes

  • Moved back the write cancel button
  • Reject drives with null size (fixes pretty-bytes error)
  • Fix typo in contributing guidelines
  • Modify versionist.conf.js to match new internal commit guidelines
  • Provide a Buffer to xxhash.Stream
  • Fix incorrect file constraint path
  • Fix flash cancel button interaction

Misc

  • Rename etcher to balena-etcher
  • Convert Select Image button to Rendition
  • Add new balena.io logos
  • Use Resin CI scripts to build Etcher
  • Enable React lint rules
  • Convert Progress Button to Rendition

Fixes T7176

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

"Burn" an .iso file on a usb stick

Diff Detail

Repository
R3610 etcher
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kyrios123 created this revision.Nov 25 2018, 1:52 AM
kyrios123 requested review of this revision.Nov 25 2018, 1:52 AM

I am quite ashamed of what I did but at least it builds. Upstream doesn't seem to take into consideration that 3rd parties could package their application.

Jacalz added a subscriber: Jacalz.Nov 25 2018, 7:29 AM

Thanks for packaging this 👍

joebonrichie accepted this revision.Dec 4 2018, 1:57 PM
joebonrichie added a subscriber: joebonrichie.

Not exactly happy with upstream with their changes, we might have to switch to repackaging the deb in future but this can go in for now. Such are electron apps. Thanks for figuring out the pain points.

This revision is now accepted and ready to land.Dec 4 2018, 1:57 PM

Not exactly happy with upstream with their changes, we might have to switch to repackaging the deb in future but this can go in for now. Such are electron apps. Thanks for figuring out the pain points.

FYI a couple of issues have been opened upstream regarding the current situation:

Jacalz added a comment.Dec 4 2018, 2:24 PM

I don’t know if it makes a difference, but my PR about pulling Git modules over https instead of ssh is merged. Should be slightly better I guess...

In D4455#72466, @Jacalz wrote:

I don’t know if it makes a difference, but my PR about pulling Git modules over https instead of ssh is merged. Should be slightly better I guess...

Yeah it will help, but we have to wait for next release/tagged version

This revision was automatically updated to reflect the committed changes.