Page MenuHomeSolus
Differential D4442

Update containerd to 1.2.0
ClosedPublic
Actions

Authored by der_eismann on Nov 23 2018, 1:58 PM.
Tags
None
Referenced Files
F11050208: D4442.id10901.diff
Thu, Aug 10, 6:50 PM
F11050206: D4442.id.diff
Thu, Aug 10, 6:50 PM
F11050205: D4442.id10976.diff
Thu, Aug 10, 6:50 PM
F11050204: D4442.id10888.diff
Thu, Aug 10, 6:50 PM
F11035789: D4442.diff
Wed, Aug 9, 6:23 PM
F11020745: D4442.id.diff
Mon, Aug 7, 8:19 AM
F10989719: D4442.diff
Mon, Jul 24, 4:58 PM
F10977399: D4442.diff
Sat, Jul 22, 3:53 PM
View All 17 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R555:797bc2c6d776: Update containerd to 1.2.0
Summary

Update to 1.2.0. Full changelog available here.

Test Plan
  • Started a daemon with sudo containerd
  • Connected with ctr version and ctr plugins

Diff Detail

Repository
R555 containerd
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

der_eismann created this revision.Nov 23 2018, 1:58 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptNov 23 2018, 1:58 PM
der_eismann requested review of this revision.Nov 23 2018, 1:58 PM
der_eismann added a child revision: D4443: Update docker to 18.09.0.Nov 23 2018, 2:04 PM
JoshStrobl requested changes to this revision.Nov 23 2018, 3:02 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
24–25

Any reason you're not just symlinking /usr/bin/containerd-shim to $installdir/usr/bin/containerd-shim-runc-v1 instead?

This revision now requires changes to proceed.Nov 23 2018, 3:02 PM
der_eismann updated this revision to Diff 10901.Nov 23 2018, 3:08 PM

Installing the correct binary

der_eismann marked an inline comment as done.Nov 23 2018, 3:09 PM
der_eismann added inline comments.
package.yml
24–25

Because I'm dumb and it's actually a separate binary

der_eismann marked 2 inline comments as done.Nov 23 2018, 3:10 PM

Thanks for noticing!

JoshStrobl accepted this revision.Nov 23 2018, 3:19 PM

Derp corrected, LGTM.

This revision is now accepted and ready to land.Nov 23 2018, 3:19 PM
Closed by commit R555:797bc2c6d776: Update containerd to 1.2.0 (authored by der_eismann, committed by JoshStrobl). · Explain WhyNov 27 2018, 4:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
18 lines
8 lines

Diff 10888

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.