Page MenuHomeSolus
Differential D440

update highlight to 3.38
ClosedPublic
Actions

Authored by mcritchlow on Jun 20 2017, 4:15 PM.
Tags
None
Referenced Files
F11028403: D440.id1033.diff
Wed, Aug 9, 6:36 AM
F11018698: D440.id1025.diff
Sun, Aug 6, 1:59 PM
F11015748: D440.id1033.diff
Sat, Aug 5, 1:51 PM
F11013071: D440.diff
Fri, Aug 4, 10:01 AM
F11008086: D440.id1033.diff
Wed, Aug 2, 12:39 AM
F10988157: D440.id1025.diff
Mon, Jul 24, 9:13 AM
F10846943: D440.diff
Jun 11 2023, 8:19 AM
F10836388: D440.diff
Jun 8 2023, 3:34 PM
View All 13 Files
Subscribers
ikey

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R1406:be9e95bac0d7: update highlight to 3.38
Summary

Changes:

  • added syntax mapping for markdown
  • added syntax mapping for clj
  • improved Java definition
  • added support for environment variable HIGHLIGHT_OPTIONS
  • fixed Bash variable highlighting issue
Test Plan

Installed locally on machine. Version reports correctly (3.38).

Integration with FZF/VIM works as expected.

Diff Detail

Repository
R1406 highlight
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mcritchlow created this revision.Jun 20 2017, 4:15 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptJun 20 2017, 4:15 PM
mcritchlow updated this revision to Diff 943.Jun 20 2017, 4:21 PM
mcritchlow edited the summary of this revision. (Show Details)

added important changes in new version

mcritchlow added a comment.Jun 20 2017, 4:30 PM

I noticed libm.so.6 was removed from the abi. I don't see an explicit -lm in the makefile or errors in reference to it, though I do see math.h included in one file. Any thoughts or advice?

ikey added a subscriber: ikey.Jun 20 2017, 5:03 PM
ikey added inline comments.
package.yml
17

This makes it impossible to then configure the package. I assume that wasn't the intended result.

mcritchlow added a comment.Jun 20 2017, 8:25 PM

@ikey -- Definitely not :) I think I'm unclear based on a change to a different ticket (D365) what the recommended approach/path is for config files. Was the original/default /etc/highlight directory acceptable? I got the sense that it wasn't. Sorry about this.

package.yml
17

Definitely not :) I think I'm unclear based on a change to a different ticket (D365) what the recommended approach/path is for config files. Was the original/default /etc/highlight directory acceptable? I got the sense that it wasn't. Sorry about this.

mcritchlow updated this revision to Diff 975.Jun 22 2017, 3:48 AM

reverting config change, leaving at default

mcritchlow edited the summary of this revision. (Show Details)Jun 22 2017, 3:49 AM
mcritchlow updated this revision to Diff 1025.Jun 24 2017, 4:45 PM

3.38 has since come out.

mcritchlow retitled this revision from update highlight to 3.37 to update highlight to 3.38.Jun 24 2017, 4:46 PM
mcritchlow edited the summary of this revision. (Show Details)
mcritchlow edited the test plan for this revision. (Show Details)
JoshStrobl accepted this revision.Jun 24 2017, 5:02 PM
This revision is now accepted and ready to land.Jun 24 2017, 5:02 PM
Closed by commit R1406:be9e95bac0d7: update highlight to 3.38 (authored by mcritchlow, committed by JoshStrobl). · Explain WhyJun 24 2017, 5:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
6 lines
6 lines

Diff 1033

View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.