Paths

Table of Contentst

Differential D4396

Initial inclusion of thonny, resolves T7040
ClosedPublic
Actions

Authored by BridouZ on Nov 19 2018, 9:46 AM.

Tags

None

Referenced Files

	F11066290: D4396.id10784.diff
	Fri, Aug 11, 5:55 PM

	F11066289: D4396.id10786.diff
	Fri, Aug 11, 5:55 PM

	F11066288: D4396.id10828.diff
	Fri, Aug 11, 5:55 PM

	F11066287: D4396.id10791.diff
	Fri, Aug 11, 5:55 PM

	F11066286: D4396.id11338.diff
	Fri, Aug 11, 5:55 PM

	F11066285: D4396.id.diff
	Fri, Aug 11, 5:55 PM

	F11047101: D4396.diff
	Thu, Aug 10, 2:47 PM

	F10984894: D4396.id10784.diff
	Sun, Jul 23, 7:24 PM

View All 21 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R4578:09bfd19ea669: Initial inclusion of thonny, resolves T7040

Summary

Changelog available here

Depends on D4393 D4394 and D4395

Test Plan

Install OK
Uses OS python3 version OK
Edit, run shell OK

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

BridouZ created this revision.Nov 19 2018, 9:46 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 19 2018, 9:46 AM

BridouZ requested review of this revision.Nov 19 2018, 9:46 AM

BridouZ edited the summary of this revision. (Show Details)Nov 19 2018, 9:48 AM

BridouZ added parent revisions: D4395: Initial inclusion of python-mypy_extensions, D4394: Initial inclusion of mypy, D4393: Initial inclusion of pyperclip.

BridouZ mentioned this in T7040: Thonny beginners python ide.

Add missing desktop file

kyrios123 added a subscriber: kyrios123.Nov 19 2018, 11:18 AM

kyrios123 added inline comments.

files/thonny.desktop
8	I think it would be cleaner to make a symbolic link to `/usr/share/pixmaps/` or `/usr/share/icons/hicolor/??x??/apps` and set only the icon file name in the desktop file. Especially in this precise case because a future stack upgrade of python to 3.7 would break this and nobody would notice until someone reports the problem. PS: Undocumented feature `%python3_version%` will return the version number (like 3.6 or 3.7, ...). You can use this for the symbolic link.
17	perhaps you can nuke the blank line.

Updated changes regarding symbolic links to thonny icons and add %python3_version%

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 20 2018, 3:16 PM

DataDrake removed a parent revision: D4394: Initial inclusion of mypy.Nov 20 2018, 3:19 PM

DataDrake added a child revision: D4394: Initial inclusion of mypy.

DataDrake removed a parent revision: D4395: Initial inclusion of python-mypy_extensions.

DataDrake removed a parent revision: D4393: Initial inclusion of pyperclip.

DataDrake added a child revision: D4393: Initial inclusion of pyperclip.

DataDrake removed a child revision: D4393: Initial inclusion of pyperclip.Nov 20 2018, 3:25 PM

DataDrake added a parent revision: D4393: Initial inclusion of pyperclip.

DataDrake removed a child revision: D4394: Initial inclusion of mypy.

DataDrake added a parent revision: D4394: Initial inclusion of mypy.

Add python-mypy_extensions as rundep

Closed by commit R4578:09bfd19ea669: Initial inclusion of thonny, resolves T7040 (authored by BridouZ, committed by DataDrake). · Explain WhyDec 11 2018, 3:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

files/

15 lines

31 lines

pspec_x86_64.xml

406 lines

Diff 11338

Makefile

Loading...

files/thonny.desktop

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...