Page MenuHomeSolus
Differential D4366

Initial commit of alacritty
ClosedPublic
Actions

Authored by robertgzr on Nov 15 2018, 12:51 PM.
Tags
None
Referenced Files
F11053157: D4366.id10696.diff
Thu, Aug 10, 10:46 PM
F11053156: D4366.id11490.diff
Thu, Aug 10, 10:46 PM
F11053155: D4366.id.diff
Thu, Aug 10, 10:46 PM
F11053154: D4366.id11478.diff
Thu, Aug 10, 10:46 PM
F11053153: D4366.id11363.diff
Thu, Aug 10, 10:46 PM
F11053152: D4366.id10714.diff
Thu, Aug 10, 10:46 PM
F11037629: D4366.diff
Wed, Aug 9, 9:00 PM
F11012568: D4366.id10696.diff
Fri, Aug 4, 4:49 AM
View All 31 Files
Subscribers
DataDrake
Girtablulu
JoshStrobl

Details

Reviewers
JoshStrobl
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T6929: Alacritty
Commits
R4608:8a2ac754348f: Initial commit of alacritty
Summary

The inclusion of alacritty resolves T6929

Signed-off-by: Robert Günzler <r@gnzler.io>

Test Plan

lsed various directories with a 2x2 grid of terminals.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

robertgzr created this revision.Nov 15 2018, 12:51 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptNov 15 2018, 12:51 PM
robertgzr requested review of this revision.Nov 15 2018, 12:51 PM
robertgzr added inline comments.Nov 15 2018, 1:04 PM
package.yml
22

How do you handle terminfo stuff?

Girtablulu added a subscriber: Girtablulu.Nov 16 2018, 2:25 PM

You can add alacritty-completions.fish as well

package.yml
6

should be Apache-2.0

9

you can remove the "" and \n

12

Not needed, should be added over '- pkgconfig(fontconfig)' dependency

18

Can be shorten to -Dm00755

19

All of them can be shorten to -Dm00644

robertgzr updated this revision to Diff 10714.Nov 16 2018, 5:41 PM

Done.

If anybody is familiar with fish, can you check that this is right.
I checked https://fishshell.com/docs/current/index.html under the "Where to put completions" section
and third-party vendor provided seemed to be appropriate.

Any advise on the terminfo installation?

JoshStrobl requested changes to this revision.Dec 6 2018, 9:48 PM
JoshStrobl added a subscriber: JoshStrobl.

Good start!

package.yml
24

Remove comment please.

25

Should get installed into /usr/share/terminfo/a after.

27–32

Should be -Dm00644 (no need for space).

This revision now requires changes to proceed.Dec 6 2018, 9:48 PM
robertgzr updated this revision to Diff 11363.Dec 11 2018, 10:31 AM

Addressed comments and updated to latest release v0.2.4

JoshStrobl requested changes to this revision.Dec 11 2018, 9:28 PM
JoshStrobl added inline comments.
package.yml
25

You still didn't address this.

This revision now requires changes to proceed.Dec 11 2018, 9:28 PM
robertgzr updated this revision to Diff 11478.Dec 16 2018, 3:19 PM

Added the terminfo files to the package

DataDrake accepted this revision.Dec 17 2018, 12:53 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 17 2018, 1:00 AM
Closed by commit R4608:8a2ac754348f: Initial commit of alacritty (authored by robertgzr, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
10 lines
28 lines
41 lines

Diff 10696

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.