Page MenuHomeSolus

Initial commit of alacritty
ClosedPublic

Authored by robertgzr on Nov 15 2018, 12:51 PM.

Details

Summary

The inclusion of alacritty resolves T6929

Signed-off-by: Robert Günzler <r@gnzler.io>

Test Plan

lsed various directories with a 2x2 grid of terminals.

Diff Detail

Repository
R4608 alacritty
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
robertgzr created this revision.Nov 15 2018, 12:51 PM
robertgzr requested review of this revision.Nov 15 2018, 12:51 PM
robertgzr added inline comments.Nov 15 2018, 1:04 PM
package.yml
23

How do you handle terminfo stuff?

You can add alacritty-completions.fish as well

package.yml
7

should be Apache-2.0

10

you can remove the "" and \n

13

Not needed, should be added over '- pkgconfig(fontconfig)' dependency

19

Can be shorten to -Dm00755

20

All of them can be shorten to -Dm00644

robertgzr updated this revision to Diff 10714.Nov 16 2018, 5:41 PM

Done.

If anybody is familiar with fish, can you check that this is right.
I checked https://fishshell.com/docs/current/index.html under the "Where to put completions" section
and third-party vendor provided seemed to be appropriate.

Any advise on the terminfo installation?

JoshStrobl requested changes to this revision.Dec 6 2018, 9:48 PM
JoshStrobl added a subscriber: JoshStrobl.

Good start!

package.yml
24

Remove comment please.

25

Should get installed into /usr/share/terminfo/a after.

27–32

Should be -Dm00644 (no need for space).

This revision now requires changes to proceed.Dec 6 2018, 9:48 PM
robertgzr updated this revision to Diff 11363.Dec 11 2018, 10:31 AM

Addressed comments and updated to latest release v0.2.4

JoshStrobl requested changes to this revision.Dec 11 2018, 9:28 PM
JoshStrobl added inline comments.
package.yml
25

You still didn't address this.

This revision now requires changes to proceed.Dec 11 2018, 9:28 PM
robertgzr updated this revision to Diff 11478.Dec 16 2018, 3:19 PM

Added the terminfo files to the package

DataDrake accepted this revision.Dec 17 2018, 12:53 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 17 2018, 1:00 AM
Closed by commit R4608:8a2ac754348f: Initial commit of alacritty (authored by robertgzr, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.