Differential D4360

Initial commit of keychain
ClosedPublic
Actions

Authored by robertgzr on Nov 15 2018, 10:09 AM.

Tags

None

Referenced Files

	F11053172: D4360.id11927.diff
	Thu, Aug 10, 10:47 PM

	F11053171: D4360.id10690.diff
	Thu, Aug 10, 10:47 PM

	F11053170: D4360.id11974.diff
	Thu, Aug 10, 10:47 PM

	F11053169: D4360.id.diff
	Thu, Aug 10, 10:47 PM

	F11037633: D4360.diff
	Wed, Aug 9, 9:01 PM

	F11003507: D4360.id11927.diff
	Mon, Jul 31, 3:15 PM

	F10981587: D4360.diff
	Sun, Jul 23, 7:08 AM

	F10976683: D4360.diff
	Sat, Jul 22, 11:13 AM

View All 17 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T7206: Add keychain

Commits

R4637:2c6dc4f4efae: Initial commit of keychain

Summary

Initial inclusion of keychain

Test Plan

Follow the guide here https://www.funtoo.org/Keychain

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

robertgzr created this revision.Nov 15 2018, 10:09 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 15 2018, 10:09 AM

robertgzr requested review of this revision.Nov 15 2018, 10:09 AM

This patch makes no mention of any cooresponding package request that has been made and is accepted for inclusion. As stated in our Submitting a Package: "If you are submitting a patch for the inclusion of software in the repo, that the package your patch pertains to has a corresponding package request that is accepted for inclusion or is a dependency of a package that has been accepted into the repository."

Do I make a package request myself?

In D4360#69533, @robertgzr wrote:

Do I make a package request myself?

There has to be a package request, which should be accepted by the core team. Then only you can present a differential.

Yes, you can create a package request yourself too.

robertgzr added a task: T7206: Add keychain.Nov 15 2018, 11:53 AM

ping

robertgzr reclaimed this revision.Dec 27 2018, 9:08 PM

Girtablulu added a subscriber: Girtablulu.Dec 28 2018, 9:32 AM

Girtablulu added inline comments.

package.yml
12	should be -Dm00755 and why not in similar fashion as below? keychain -t $installdir/usr/bin
13	should be -Dm00644

Fixes according to review

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 31 2018, 6:10 PM

Closed by commit R4637:2c6dc4f4efae: Initial commit of keychain (authored by robertgzr, committed by DataDrake). · Explain WhyJan 1 2019, 1:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

13 lines

pspec_x86_64.xml

35 lines

Diff 10690

Makefile

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...