Page MenuHomeSolus

Initial commit of keychain

Authored by robertgzr on Nov 15 2018, 10:09 AM.



Initial inclusion of keychain

Test Plan

Follow the guide here

Diff Detail

R4637 keychain
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

robertgzr created this revision.Nov 15 2018, 10:09 AM
robertgzr requested review of this revision.Nov 15 2018, 10:09 AM
JoshStrobl abandoned this revision.Nov 15 2018, 10:17 AM
JoshStrobl added a subscriber: JoshStrobl.

This patch makes no mention of any cooresponding package request that has been made and is accepted for inclusion. As stated in our Submitting a Package: "If you are submitting a patch for the inclusion of software in the repo, that the package your patch pertains to has a corresponding package request that is accepted for inclusion or is a dependency of a package that has been accepted into the repository."

Do I make a package request myself?

Do I make a package request myself?

There has to be a package request, which should be accepted by the core team. Then only you can present a differential.

Yes, you can create a package request yourself too.

robertgzr reclaimed this revision.Dec 27 2018, 9:08 PM
Girtablulu added inline comments.

should be -Dm00755 and why not in similar fashion as below?
keychain -t $installdir/usr/bin


should be -Dm00644

robertgzr updated this revision to Diff 11927.Dec 29 2018, 5:10 PM

Fixes according to review

DataDrake accepted this revision.Dec 31 2018, 6:10 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 31 2018, 6:10 PM
This revision was automatically updated to reflect the committed changes.