Differential D4343

Update yacreader to 9.5.0
ClosedPublic
Actions

Authored by Girtablulu on Nov 13 2018, 9:59 AM.

Tags

None

Referenced Files

	F11068857: D4343.id10670.diff
	Fri, Aug 11, 10:18 PM

	F11068856: D4343.id10661.diff
	Fri, Aug 11, 10:18 PM

	F11061545: D4343.id10662.diff
	Fri, Aug 11, 11:19 AM

	F11050894: D4343.diff
	Thu, Aug 10, 7:33 PM

	F11007639: D4343.diff
	Tue, Aug 1, 9:21 PM

	F10935301: D4343.diff
	Jul 12 2023, 7:47 PM

	F10887815: D4343.id10670.diff
	Jun 26 2023, 5:06 PM

	F10887375: D4343.id10663.diff
	Jun 26 2023, 11:05 AM

View All 15 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R4487:f34484ca1e92: Update yacreader to 9.5.0

Summary

Update yacreader to 9.5.0
Changelog:
Link

Test Plan

Opened a Comic and created a new libary

Diff Detail

Repository

R4487 yacreader

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Girtablulu created this revision.Nov 13 2018, 9:59 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 13 2018, 9:59 AM

Girtablulu requested review of this revision.Nov 13 2018, 9:59 AM

Two things:

1,You can use https://github.com/YACReader/yacreader/blob/9.5.0/CHANGELOG.md as the link to the changelog (i.e. it will remain at the 9.5.0 changes till the end of time, which are the only relevant changes to the commit).

How come pkgconfig(Qt5QuickControls2)? Looking at the code it's only qt5-quickcontrols (which also needs to be added as a rundep for the QML view).

This revision now requires changes to proceed.Nov 13 2018, 10:22 AM

Add quickcontroll as rundep and fixed changelog link

Without quickcontrol2 it throws me an error while building and it never complained about a missing rundep

In D4343#69358, @Girtablulu wrote:

Without quickcontrol2 it throws me an error while building and it never complained about a missing rundep

pkgconfig(Qt5Quick) is the actual requirement. qt5-quickcontrols is needed for the qml files https://github.com/YACReader/yacreader/blob/master/YACReaderLibrary/qml/ComicInfoView.qml

Switch to builddep pkgconfig(qt5quick) instead of quickcontrol

• sunnyflunk accepted this revision.Nov 14 2018, 12:43 AM

This revision is now accepted and ready to land.Nov 14 2018, 12:43 AM

Closed by commit R4487:f34484ca1e92: Update yacreader to 9.5.0 (authored by Girtablulu, committed by • sunnyflunk). · Explain WhyNov 14 2018, 12:44 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

2 lines

16 lines

pspec_x86_64.xml

6 lines

Diff 10670

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...