Update picard to 2.0.4
ClosedPublic
Actions

Authored by livingsilver94 on Nov 11 2018, 9:14 PM.

Details

Reviewers

DataDrake

Group Reviewers

Triage Team

Commits

R2427:679abbc250a4: Update picard to 2.0.4

Summary

Fixed bugs:

tagging "8½ Minutes" with "replace with non-ascii characters" results in a directory being created
Does not display version information
Picard has wrong version string
Crashes every time Picard connects to MB server.
Picard crashes on clearing log
RuntimeError: dictionary changed size during iteration
CD drive selection not working on Linux
Crash in options on "Restore defaults"
Restore defaults does not restore CAA types
Default locale not working reliable
Picard Save Changes 5.1 Mix Type
Loading TAK files fails
Loading OptimFROG files fails
Picard fails saving ID3 tags with iTunNORM tag
Picard crashes on error during plugin install

Test Plan

Tests passed. Successfully tagged a bunch of albums

Diff Detail

Repository

R2427 picard

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

livingsilver94 created this revision.Nov 11 2018, 9:14 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 11 2018, 9:14 PM

livingsilver94 requested review of this revision.Nov 11 2018, 9:14 PM

Qt5 theme is not consistent, but it's probably a python-qt5's issue.

2.0.0dev6 crash in debug mode on Windows April Update (1803)

In the future, stuff like this should be removed from the conflict. This might surprise you but we're actually Solus, not Windows :P

Qt5 theme is not consistent, but it's probably a python-qt5's issue.

Is there a bug filed against this?

In D4329#69282, @JoshStrobl wrote:

2.0.0dev6 crash in debug mode on Windows April Update (1803)

In the future, stuff like this should be removed from the conflict. This might surprise you but we're actually Solus, not Windows :P

Makes sense :P

In D4329#69282, @JoshStrobl wrote:

Is there a bug filed against this?

I couldn't find any bug filed for Picard regarding that issue, I'll investigate further. Anyways, the theme was inconsistent in the previous version too.
Actually, the python-qt5 package we have in the repo is outdated and has a complicated installation method. The upstream README is way simpler.