Page MenuHomeSolus

Update to 1.5.3
ClosedPublic

Authored by ma-renaud on Nov 9 2018, 4:58 PM.
Tags
None
Referenced Files
F11066428: D4303.id.diff
Fri, Aug 11, 6:04 PM
F11066427: D4303.id10568.diff
Fri, Aug 11, 6:04 PM
F11066426: D4303.id10566.diff
Fri, Aug 11, 6:04 PM
F11066425: D4303.id10558.diff
Fri, Aug 11, 6:04 PM
F11047176: D4303.diff
Thu, Aug 10, 2:57 PM
F10976766: D4303.id10568.diff
Sat, Jul 22, 11:46 AM
F10866266: D4303.id10574.diff
Jun 17 2023, 2:41 PM
F10865374: D4303.id10558.diff
Jun 17 2023, 11:14 AM

Details

Summary

Google changed the protocol again and this fixes it.

  • New version of hangupsjs.
  • Fix The "url" argument must be of type string, received type object.
  • Fix own messages showing as unread.
  • Fix popup showing wrong text when opening links.
Test Plan

Tested chat functionality, image transfer, language change, start minimized, close to tray, color schemes, notifications and key shortcuts

Diff Detail

Repository
R3295 yakyak
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joebonrichie added a subscriber: joebonrichie.

Please cleanup the changelog - avoid citing specific numbers of bug report numbers or pull requests such as 'Closes #999 and others'. A slightly more detailed testplan would able be appreciated such as tested 'Microphone and Webcam input', 'Tested chat functionality', stuff like that

This revision now requires changes to proceed.Nov 9 2018, 6:42 PM
ma-renaud edited the summary of this revision. (Show Details)
ma-renaud edited the test plan for this revision. (Show Details)

Edited initial changelog.

You should also remove the things that are not related to linux like

Fix inset border in OSX.

ma-renaud edited the summary of this revision. (Show Details)

Remove changes not related to linux.

sunnyflunk edited the test plan for this revision. (Show Details)
sunnyflunk added a subscriber: sunnyflunk.

Thanks, I will look at backporting this, since it was mentioned on IRC that this would be broken with the new protocol.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 10 2018, 3:22 AM
Closed by commit R3295:ddaea59e110b: Update to 1.5.3 (authored by ma-renaud, committed by sunnyflunk). · Explain Why
This revision was automatically updated to reflect the committed changes.