Page MenuHomeSolus

Update brave to 0.25.2 to fix a lot of security issues
AbandonedPublic

Authored by Jacalz on Nov 3 2018, 11:44 AM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

This updates brave to the as of now latest version of the old
brave code base. Notable changes include:

  • Security issues with NoScript and Chrome://brave
  • Npm packages upgraded to fix a couple security issues
  • Updates chromium engine to a newer version
  • A couple bugfixes and improvements

Packaging changes:

  • Running npm audit fix to automatically fix a couple security voulnerabilities reported by npm at build time. Currently npm reports brave to have zero known voulnerabilities after running the fix.
Test Plan
  • Install brave and browse the web like a majestic lion

Diff Detail

Repository
R4107 brave
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Jacalz created this revision.Nov 3 2018, 11:44 AM
Jacalz requested review of this revision.Nov 3 2018, 11:44 AM
Jacalz updated this revision to Diff 10440.Nov 3 2018, 11:48 AM

Fix release number

Hey Jacalz, we are actually already updating Brave to 0.55.22 in D4196.

Jacalz added a comment.Nov 5 2018, 5:19 AM

Ah, had totally missen that one! Will abandon this...

Jacalz added a comment.Nov 5 2018, 5:27 AM

Can’t figure out how to abandon this...

alecbcs abandoned this revision.Nov 5 2018, 6:03 AM

No worries, I've honestly been in the same situation and written duplicate patches a couple of times. Even though it was a duplicate, thank you for taking the initiative!