Page MenuHomeSolus

Updated Brave to 0.56.12
ClosedPublic

Authored by alecbcs on Oct 28 2018, 8:28 PM.

Details

Summary

Updated Brave to 0.56.12 which is a major update to the new Brave browser that is now based off chromium rather than the previous muon interface. This update is unfortunetly built off of the binary package because building brave from source now requires we build chromium from source as well which requires around 11GB of files.
Sumarized Changelog:

  • Updated the Brave shields panel with a new design.
  • Added support for direct YouTube donations using the Rewards panel.
  • Added global Brave shield settings into preferences.
  • Added exclude / include option to the Rewards panel.
  • Added "Creating Wallet" message when enabling Rewards for the first time using the Rewards panel.
  • Added search engine shortcut keys.
  • Fixed Hulu not playing in Brave
  • Fixed PDFs protected by cookie based login not loading.
  • Fixed favicons not being displayed for media publisher in the Rewards panel.

The full changelog can be found here

Test Plan

Tested 0.56.12 by opening multiple tabs and websites. Everything functioned and looked as expected.

Diff Detail

Repository
R4107 brave
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alecbcs created this revision.Oct 28 2018, 8:28 PM
alecbcs requested review of this revision.Oct 28 2018, 8:28 PM
alecbcs updated this revision to Diff 10466.Nov 5 2018, 12:45 AM
  • Update Brave to 0.55.22
alecbcs retitled this revision from Updated Brave to 0.55.20 to Updated Brave to 0.55.22.Nov 5 2018, 12:48 AM
JoshStrobl requested changes to this revision.Nov 5 2018, 5:33 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
34

Nononono. We do not allow stuff to go into /opt. Not to mention you should be using $installdir not %installroot%

This revision now requires changes to proceed.Nov 5 2018, 5:33 PM
Jacalz awarded a token.Nov 5 2018, 6:02 PM
Jacalz added a subscriber: Jacalz.
Jacalz added a comment.EditedNov 6 2018, 6:49 AM

How does this handle the profile a user has from the old Brave? Do the old profile launch in this one or does the user need to go in and import his profile?

If not this commit be of interest:
https://github.com/brave/brave-core/commit/b151293572706109422527a46532bc0ae410fb1a

Jacalz added a comment.Nov 9 2018, 6:48 PM

A new version (0.56.12) has ben released, I would recommend to update this...

alecbcs updated this revision to Diff 10702.Nov 15 2018, 10:14 PM
  • Update Brave to 0.56.12
alecbcs retitled this revision from Updated Brave to 0.55.22 to Updated Brave to 0.56.12.Nov 15 2018, 10:19 PM
alecbcs edited the summary of this revision. (Show Details)
alecbcs edited the test plan for this revision. (Show Details)
alecbcs marked an inline comment as done.Nov 15 2018, 10:23 PM

Sorry for the delay getting this updated to the latest version. Had a busy couple of weeks and wanted to sit down and do this right. I attempted to implement the --upgrade-from-muon flag. However, the script appears to read from the wrong config location so it doesn't have an effect when upgrading on Solus.

Would it be possible to modify the script with a patch to get it working?

Unfortunately, because we are using the binary rather than building it from source I don't believe there is anyway to change the script which is compiled into brave-core. I'm still exploring ways to build this package from source in the future but because of the large chromium repository it makes it fairly hard to build with ypkg.

Okay that’s unfortunate for users that are already using brave, but it will have to do then. Guess we need to inform the user that they will need to import their profile after updating, unless a PR gets sent in upstream to add support for Solus.

JoshStrobl requested changes to this revision.Nov 18 2018, 2:07 PM
JoshStrobl added inline comments.
package.yml
32–34

Should be using $installdir, as I stated in my comment earlier.

This revision now requires changes to proceed.Nov 18 2018, 2:07 PM
alecbcs updated this revision to Diff 10799.Nov 19 2018, 11:52 PM
alecbcs edited the summary of this revision. (Show Details)
  • Replaced %installroot% with $installdir
alecbcs marked an inline comment as done.Nov 19 2018, 11:54 PM
alecbcs added inline comments.
package.yml
32–34

Sorry, about that. Should be fixed now. Thanks for the reminder :)

alecbcs marked 2 inline comments as done.Nov 19 2018, 11:55 PM
JoshStrobl accepted this revision.Nov 23 2018, 2:56 PM

LGTM, thank you for your continued maintainership of this package :)

This revision is now accepted and ready to land.Nov 23 2018, 2:56 PM
This revision was automatically updated to reflect the committed changes.
logTom added a subscriber: logTom.Nov 26 2018, 9:09 AM

Wow, just got this updated. Last week I checked if other distros got this included - none of them had - seriously even on the arch aur there was just a barely working sandbox bin version of this. You guys are doing an awesome work! I really hope you get that patreon up and running soon again and give that package maintainers a fair share of that money!!!