Page MenuHomeSolus

Initial commit of onedrive

Authored by Staudey on Oct 27 2018, 10:51 PM.
Referenced Files
F10804361: D4172.id11228.diff
Mon, May 29, 3:49 PM
Mon, May 29, 5:34 AM
Fri, May 26, 6:00 AM
F10749144: D4172.id11228.diff
Tue, May 16, 12:12 AM
F10749111: D4172.id11348.diff
Tue, May 16, 12:01 AM
F10749028: D4172.id10278.diff
Mon, May 15, 11:43 PM
F10724440: D4172.diff
Sun, May 7, 3:45 PM
F10722370: D4172.id10278.diff
Sat, May 6, 7:46 PM



Initial commit of onedrive

See T6981

Test Plan

Run "onedrive" from Terminal, connect to my OneDrive and download files

Diff Detail

R4605 onedrive
Lint Not Applicable
Tests Not Applicable

Event Timeline

Staudey edited the summary of this revision. (Show Details)

The sed-stuff is because the original Makefile tries to get git version information, which obviously doesn't work with the tar.gz archive and is a bit silly for a release.

DataDrake added a subscriber: DataDrake.

Can we just name this onedrive to match upstream?

This revision now requires changes to proceed.Nov 5 2018, 5:36 PM
kyrios123 added inline comments.

How about using $version instead of hardcoded version number ?

@DataDrake Fine by me, I wasn't sure what to do here to be honest. I just thought calling it "OneDrive" would make it sound like an official Microsoft app, and took the name from the Task, which is also the header of the Readme.

@kyrios123: I definitely will fix that; not sure why I didn't do it like that anyway.

Fix package name and don't hardcode version in setup

Staudey retitled this revision from Initial commit of onedrive-free-client to Initial commit of onedrive.Nov 5 2018, 9:14 PM
Staudey edited the summary of this revision. (Show Details)

Need to update the pspec too.

This revision now requires changes to proceed.Nov 20 2018, 3:02 PM

Actually update pspec.xml too

JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.

Should go before builddeps.


Nonononono. You need to sort out the PREFIX so it goes to /usr/bin

This revision now requires changes to proceed.Dec 7 2018, 12:13 AM

Fix builddeps order, fix PREFIX

Staudey added inline comments.

Gotcha, I thought it should be in alphabetical order as a whole


Oh, I didn't even notice this. I fixed it, if this method is okay.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 11 2018, 3:51 AM
Closed by commit R4605:657a27b4c178: Initial commit of onedrive (authored by Staudey, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.