Page MenuHomeSolus
Differential D4172

Initial commit of onedrive
ClosedPublic
Actions

Authored by Staudey on Oct 27 2018, 10:51 PM.

Details

Reviewers
DataDrake
JoshStrobl
Group Reviewers
Triage Team
Commits
R4605:657a27b4c178: Initial commit of onedrive
Summary

Initial commit of onedrive

See T6981

Test Plan

Run "onedrive" from Terminal, connect to my OneDrive and download files

Diff Detail

Repository
R4605 onedrive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Oct 27 2018, 10:51 PM
Staudey requested review of this revision.Oct 27 2018, 10:51 PM
Staudey edited the summary of this revision. (Show Details)Oct 27 2018, 10:52 PM
Staudey edited the summary of this revision. (Show Details)
Staudey added a comment.Oct 27 2018, 10:54 PM

The sed-stuff is because the original Makefile tries to get git version information, which obviously doesn't work with the tar.gz archive and is a bit silly for a release.

DataDrake requested changes to this revision.Nov 5 2018, 5:36 PM
DataDrake added a subscriber: DataDrake.

Can we just name this onedrive to match upstream?

This revision now requires changes to proceed.Nov 5 2018, 5:36 PM
kyrios123 added a subscriber: kyrios123.Nov 5 2018, 5:43 PM
kyrios123 added inline comments.
package.yml
18

How about using $version instead of hardcoded version number ?

Staudey added a comment.Nov 5 2018, 8:58 PM

@DataDrake Fine by me, I wasn't sure what to do here to be honest. I just thought calling it "OneDrive" would make it sound like an official Microsoft app, and took the name from the Task, which is also the header of the Readme.

@kyrios123: I definitely will fix that; not sure why I didn't do it like that anyway.

Staudey updated this revision to Diff 10499.Nov 5 2018, 9:09 PM

Fix package name and don't hardcode version in setup

Staudey marked an inline comment as done.Nov 5 2018, 9:10 PM
Staudey retitled this revision from Initial commit of onedrive-free-client to Initial commit of onedrive.Nov 5 2018, 9:14 PM
Staudey edited the summary of this revision. (Show Details)
DataDrake requested changes to this revision.Nov 20 2018, 3:02 PM

Need to update the pspec too.

This revision now requires changes to proceed.Nov 20 2018, 3:02 PM
Staudey updated this revision to Diff 10829.Nov 20 2018, 6:10 PM

Actually update pspec.xml too

JoshStrobl requested changes to this revision.Dec 7 2018, 12:13 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
14–15

Should go before builddeps.

pspec_x86_64.xml
24

Nonononono. You need to sort out the PREFIX so it goes to /usr/bin

This revision now requires changes to proceed.Dec 7 2018, 12:13 AM
Staudey updated this revision to Diff 11228.Dec 7 2018, 3:23 PM

Fix builddeps order, fix PREFIX

Staudey marked an inline comment as done.Dec 7 2018, 3:24 PM
Staudey added inline comments.
package.yml
14–15

Gotcha, I thought it should be in alphabetical order as a whole

pspec_x86_64.xml
24

Oh, I didn't even notice this. I fixed it, if this method is okay.

Staudey marked 4 inline comments as done.Dec 7 2018, 3:25 PM
DataDrake accepted this revision.Dec 11 2018, 3:50 AM

LGTM. thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 11 2018, 3:51 AM
Closed by commit R4605:657a27b4c178: Initial commit of onedrive (authored by Staudey, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMMakefile (1 line)
AMabi_used_libs (7 lines)
AMpackage.yml (24 lines)
AMpspec_x86_64.xml (35 lines)

Diff 11348

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2019 Solus Project. The Solus logo is Copyright © 2016-2019 Solus Project. All Rights Reserved.