Details

Reviewers

DataDrake
JoshStrobl

Group Reviewers

Triage Team

Commits

R4605:657a27b4c178: Initial commit of onedrive

Summary

Initial commit of onedrive

See T6981

Test Plan

Run "onedrive" from Terminal, connect to my OneDrive and download files

Diff Detail

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Staudey created this revision.Oct 27 2018, 10:51 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 27 2018, 10:51 PM

Staudey requested review of this revision.Oct 27 2018, 10:51 PM

Staudey edited the summary of this revision. (Show Details)Oct 27 2018, 10:52 PM

Staudey edited the summary of this revision. (Show Details)

The sed-stuff is because the original Makefile tries to get git version information, which obviously doesn't work with the tar.gz archive and is a bit silly for a release.

Can we just name this onedrive to match upstream?

This revision now requires changes to proceed.Nov 5 2018, 5:36 PM

kyrios123 added a subscriber: kyrios123.Nov 5 2018, 5:43 PM

kyrios123 added inline comments.

package.yml
17	How about using `$version` instead of hardcoded version number ?

@DataDrake Fine by me, I wasn't sure what to do here to be honest. I just thought calling it "OneDrive" would make it sound like an official Microsoft app, and took the name from the Task, which is also the header of the Readme.

@kyrios123: I definitely will fix that; not sure why I didn't do it like that anyway.

Fix package name and don't hardcode version in setup

Staudey marked an inline comment as done.Nov 5 2018, 9:10 PM

Staudey retitled this revision from Initial commit of onedrive-free-client to Initial commit of onedrive.Nov 5 2018, 9:14 PM

Staudey edited the summary of this revision. (Show Details)

xulongwu4 added a subscriber: xulongwu4.Nov 14 2018, 6:19 PM

Need to update the pspec too.

This revision now requires changes to proceed.Nov 20 2018, 3:02 PM

Actually update pspec.xml too

JoshStrobl requested changes to this revision.Dec 7 2018, 12:13 AM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
14–15	Should go before builddeps.
pspec_x86_64.xml
24	Nonononono. You need to sort out the PREFIX so it goes to `/usr/bin`

This revision now requires changes to proceed.Dec 7 2018, 12:13 AM

Fix builddeps order, fix PREFIX

Staudey marked an inline comment as done.Dec 7 2018, 3:24 PM

Staudey added inline comments.

package.yml
14–15	Gotcha, I thought it should be in alphabetical order as a whole
pspec_x86_64.xml
24	Oh, I didn't even notice this. I fixed it, if this method is okay.

Staudey marked 4 inline comments as done.Dec 7 2018, 3:25 PM

LGTM. thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 11 2018, 3:51 AM

Closed by commit R4605:657a27b4c178: Initial commit of onedrive (authored by Staudey, committed by DataDrake). · Explain Why

This revision was automatically updated to reflect the committed changes.

		Path
A	M	Makefile (1 line)
A	M	abi_used_libs (7 lines)
A	M	package.yml (21 lines)
A	M	pspec_x86_64.xml (35 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10278	4b825dc		Oct 27 2018, 10:51 PM	★	★
Diff 2	10499	4b825dc	Fix package name and don't hardcode version in setup	Nov 5 2018, 9:09 PM	★	★
Diff 3	10829	4b825dc	Actually update pspec.xml too	Nov 20 2018, 6:10 PM	★	★
Diff 4	11228	4b825dc	Fix builddeps order, fix PREFIX	Dec 7 2018, 3:23 PM	★	★
Diff 5	11348	61cb5c1	R4605:657a27b4c178b7031b44f53e65c0bd1ef6daed34	Dec 11 2018, 3:51 AM	★	★

Initial commit of onedrive
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 10278

Makefile

abi_used_libs

package.yml

pspec_x86_64.xml

Initial commit of onedriveClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 10278

Makefile

abi_used_libs

package.yml

pspec_x86_64.xml

Initial commit of onedrive
ClosedPublic
Actions

Revision Contents
Changeset List